Source/modules/websockets/WebSocketChannel.h - Issue 222153002: Disallow connecting an insecure WebSocket from a secure page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/websockets/WebSocketChannel.h

Issue 222153002: Disallow connecting an insecure WebSocket from a secure page. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/websockets/WebSocketChannel.h

diff --git a/Source/modules/websockets/WebSocketChannel.h b/Source/modules/websockets/WebSocketChannel.h

index fe63eaa7c197da14c46cd7677662f12428e75d5c..4059f24d8c47a3c48646e8959e7c705d9cb739ed 100644

--- a/Source/modules/websockets/WebSocketChannel.h

+++ b/Source/modules/websockets/WebSocketChannel.h

@@ -75,7 +75,7 @@ public:

CloseEventCodeMaximumUserDefined = 4999

};

- virtual void connect(const KURL&, const String& protocol) = 0;

+ virtual bool connect(const KURL&, const String& protocol) = 0;

virtual String subprotocol() = 0; // Will be available after didConnect() callback is invoked.

virtual String extensions() = 0; // Will be available after didConnect() callback is invoked.

virtual SendResult send(const String& message) = 0;