Source/modules/websockets/NewWebSocketChannelImpl.h - Issue 222153002: Disallow connecting an insecure WebSocket from a secure page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/websockets/NewWebSocketChannelImpl.h

Issue 222153002: Disallow connecting an insecure WebSocket from a secure page. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/websockets/NewWebSocketChannelImpl.h

diff --git a/Source/modules/websockets/NewWebSocketChannelImpl.h b/Source/modules/websockets/NewWebSocketChannelImpl.h

index 2cc3355ca6777f1447b5ba8a14831c9242b0ab60..a3bf6587c0c2a6e5e0500f76a5aab5e831ba35dc 100644

--- a/Source/modules/websockets/NewWebSocketChannelImpl.h

+++ b/Source/modules/websockets/NewWebSocketChannelImpl.h

@@ -77,7 +77,7 @@ public:

virtual ~NewWebSocketChannelImpl();

// WebSocketChannel functions.

- virtual void connect(const KURL&, const String& protocol) OVERRIDE;

+ virtual bool connect(const KURL&, const String& protocol) OVERRIDE;

virtual String subprotocol() OVERRIDE;

virtual String extensions() OVERRIDE;

virtual WebSocketChannel::SendResult send(const String& message) OVERRIDE;