Move ct_skps recipe from tools repo to Skia repo

Move ct_skps recipe from tools repo to Skia repo.
Also move the isolate file and script from Chromium repo to the Skia repo.

BUG=skia:5620
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2221413002

Committed: https://skia.googlesource.com/skia/+/5eab99183c5dd74e24176daef8f742d61a7aeab3

[rmistry, 2016-08-09 16:46:43]

Description was changed from

==========
Move ct_skps recipe from tools repo to Skia repo. Also move the isolate file and
script from Chromium repo to the Skia repo.

BUG=skia:5620
==========

to

==========
Move ct_skps recipe from tools repo to Skia repo. Also move the isolate file and
script from Chromium repo to the Skia repo.

BUG=skia:5620
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2221413002
==========

[rmistry, 2016-08-09 16:51:52]

Patchset #2 (id:20001) has been deleted

[rmistry, 2016-08-09 16:54:41]

Patchset #2 (id:30001) has been deleted

[rmistry, 2016-08-09 16:55:28]

Description was changed from

==========
Move ct_skps recipe from tools repo to Skia repo. Also move the isolate file and
script from Chromium repo to the Skia repo.

BUG=skia:5620
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2221413002
==========

to

==========
Move ct_skps recipe from tools repo to Skia repo.
Also move the isolate file and script from Chromium repo to the Skia repo.

BUG=skia:5620
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2221413002
==========

[rmistry, 2016-08-09 16:57:11]

rmistry@google.com changed reviewers:
+ borenet@google.com

[rmistry, 2016-08-09 16:57:12]

Easiest way to review this will be to diff with patchset1.

[borenet, 2016-08-09 17:10:21]

Just a couple of comments.

https://codereview.chromium.org/2221413002/diff/40001/infra/bots/ct/ct_skps.i...
File infra/bots/ct/ct_skps.isolate (right):

https://codereview.chromium.org/2221413002/diff/40001/infra/bots/ct/ct_skps.i...
infra/bots/ct/ct_skps.isolate:10: '../../../resources/',
Include resources.isolate instead.

https://codereview.chromium.org/2221413002/diff/40001/infra/bots/recipe_modul...
File infra/bots/recipe_modules/run/api.py (right):

https://codereview.chromium.org/2221413002/diff/40001/infra/bots/recipe_modul...
infra/bots/recipe_modules/run/api.py:68: 'skia', 'infra', 'bots',
'.recipe_deps', 'build', 'scripts'))
Can you move this change into a separate CL and land it first?  It may change
behavior on other bots and I'd like to stage that separately if possible.

https://codereview.chromium.org/2221413002/diff/40001/infra/bots/recipes/swar...
File infra/bots/recipes/swarm_ct_skps.py (right):

https://codereview.chromium.org/2221413002/diff/40001/infra/bots/recipes/swar...
infra/bots/recipes/swarm_ct_skps.py:154: isolate_dir = infrabots_dir.join('ct')
isolate_dir is already defined above, shouldn't have to do it again here.

[rmistry, 2016-08-09 18:18:50]

Patchset #4 (id:60001) has been deleted

[rmistry, 2016-08-09 18:19:11]

https://codereview.chromium.org/2221413002/diff/40001/infra/bots/ct/ct_skps.i...
File infra/bots/ct/ct_skps.isolate (right):

https://codereview.chromium.org/2221413002/diff/40001/infra/bots/ct/ct_skps.i...
infra/bots/ct/ct_skps.isolate:10: '../../../resources/',
On 2016/08/09 17:10:21, borenet wrote:
> Include resources.isolate instead.

Done.

https://codereview.chromium.org/2221413002/diff/40001/infra/bots/recipe_modul...
File infra/bots/recipe_modules/run/api.py (right):

https://codereview.chromium.org/2221413002/diff/40001/infra/bots/recipe_modul...
infra/bots/recipe_modules/run/api.py:68: 'skia', 'infra', 'bots',
'.recipe_deps', 'build', 'scripts'))
On 2016/08/09 17:10:21, borenet wrote:
> Can you move this change into a separate CL and land it first?  It may change
> behavior on other bots and I'd like to stage that separately if possible.

Done: https://codereview.chromium.org/2221423002/#

Leaving this change here to make it easier to test, will merge before
submitting.

https://codereview.chromium.org/2221413002/diff/40001/infra/bots/recipes/swar...
File infra/bots/recipes/swarm_ct_skps.py (right):

https://codereview.chromium.org/2221413002/diff/40001/infra/bots/recipes/swar...
infra/bots/recipes/swarm_ct_skps.py:154: isolate_dir = infrabots_dir.join('ct')
On 2016/08/09 17:10:21, borenet wrote:
> isolate_dir is already defined above, shouldn't have to do it again here.

Done.

[borenet, 2016-08-09 18:59:40]

On 2016/08/09 18:19:11, rmistry wrote:
>
https://codereview.chromium.org/2221413002/diff/40001/infra/bots/ct/ct_skps.i...
> File infra/bots/ct/ct_skps.isolate (right):
> 
>
https://codereview.chromium.org/2221413002/diff/40001/infra/bots/ct/ct_skps.i...
> infra/bots/ct/ct_skps.isolate:10: '../../../resources/',
> On 2016/08/09 17:10:21, borenet wrote:
> > Include resources.isolate instead.
> 
> Done.
> 
>
https://codereview.chromium.org/2221413002/diff/40001/infra/bots/recipe_modul...
> File infra/bots/recipe_modules/run/api.py (right):
> 
>
https://codereview.chromium.org/2221413002/diff/40001/infra/bots/recipe_modul...
> infra/bots/recipe_modules/run/api.py:68: 'skia', 'infra', 'bots',
> '.recipe_deps', 'build', 'scripts'))
> On 2016/08/09 17:10:21, borenet wrote:
> > Can you move this change into a separate CL and land it first?  It may
change
> > behavior on other bots and I'd like to stage that separately if possible.
> 
> Done: https://codereview.chromium.org/2221423002/
> 
> Leaving this change here to make it easier to test, will merge before
> submitting.
> 
>
https://codereview.chromium.org/2221413002/diff/40001/infra/bots/recipes/swar...
> File infra/bots/recipes/swarm_ct_skps.py (right):
> 
>
https://codereview.chromium.org/2221413002/diff/40001/infra/bots/recipes/swar...
> infra/bots/recipes/swarm_ct_skps.py:154: isolate_dir =
infrabots_dir.join('ct')
> On 2016/08/09 17:10:21, borenet wrote:
> > isolate_dir is already defined above, shouldn't have to do it again here.
> 
> Done.

LGTM ::tremble::

[rmistry, 2016-08-09 19:00:56]

On 2016/08/09 18:59:40, borenet wrote:
> On 2016/08/09 18:19:11, rmistry wrote:
> >
>
https://codereview.chromium.org/2221413002/diff/40001/infra/bots/ct/ct_skps.i...
> > File infra/bots/ct/ct_skps.isolate (right):
> > 
> >
>
https://codereview.chromium.org/2221413002/diff/40001/infra/bots/ct/ct_skps.i...
> > infra/bots/ct/ct_skps.isolate:10: '../../../resources/',
> > On 2016/08/09 17:10:21, borenet wrote:
> > > Include resources.isolate instead.
> > 
> > Done.
> > 
> >
>
https://codereview.chromium.org/2221413002/diff/40001/infra/bots/recipe_modul...
> > File infra/bots/recipe_modules/run/api.py (right):
> > 
> >
>
https://codereview.chromium.org/2221413002/diff/40001/infra/bots/recipe_modul...
> > infra/bots/recipe_modules/run/api.py:68: 'skia', 'infra', 'bots',
> > '.recipe_deps', 'build', 'scripts'))
> > On 2016/08/09 17:10:21, borenet wrote:
> > > Can you move this change into a separate CL and land it first?  It may
> change
> > > behavior on other bots and I'd like to stage that separately if possible.
> > 
> > Done: https://codereview.chromium.org/2221423002/
> > 
> > Leaving this change here to make it easier to test, will merge before
> > submitting.
> > 
> >
>
https://codereview.chromium.org/2221413002/diff/40001/infra/bots/recipes/swar...
> > File infra/bots/recipes/swarm_ct_skps.py (right):
> > 
> >
>
https://codereview.chromium.org/2221413002/diff/40001/infra/bots/recipes/swar...
> > infra/bots/recipes/swarm_ct_skps.py:154: isolate_dir =
> infrabots_dir.join('ct')
> > On 2016/08/09 17:10:21, borenet wrote:
> > > isolate_dir is already defined above, shouldn't have to do it again here.
> > 
> > Done.
> 
> LGTM ::tremble::

Submitting this should have no change till builders in builder.cfg are moved
over to use the default recipe?

[borenet, 2016-08-09 19:02:21]

On 2016/08/09 19:00:56, rmistry wrote:
> On 2016/08/09 18:59:40, borenet wrote:
> > On 2016/08/09 18:19:11, rmistry wrote:
> > >
> >
>
https://codereview.chromium.org/2221413002/diff/40001/infra/bots/ct/ct_skps.i...
> > > File infra/bots/ct/ct_skps.isolate (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2221413002/diff/40001/infra/bots/ct/ct_skps.i...
> > > infra/bots/ct/ct_skps.isolate:10: '../../../resources/',
> > > On 2016/08/09 17:10:21, borenet wrote:
> > > > Include resources.isolate instead.
> > > 
> > > Done.
> > > 
> > >
> >
>
https://codereview.chromium.org/2221413002/diff/40001/infra/bots/recipe_modul...
> > > File infra/bots/recipe_modules/run/api.py (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2221413002/diff/40001/infra/bots/recipe_modul...
> > > infra/bots/recipe_modules/run/api.py:68: 'skia', 'infra', 'bots',
> > > '.recipe_deps', 'build', 'scripts'))
> > > On 2016/08/09 17:10:21, borenet wrote:
> > > > Can you move this change into a separate CL and land it first?  It may
> > change
> > > > behavior on other bots and I'd like to stage that separately if
possible.
> > > 
> > > Done: https://codereview.chromium.org/2221423002/
> > > 
> > > Leaving this change here to make it easier to test, will merge before
> > > submitting.
> > > 
> > >
> >
>
https://codereview.chromium.org/2221413002/diff/40001/infra/bots/recipes/swar...
> > > File infra/bots/recipes/swarm_ct_skps.py (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2221413002/diff/40001/infra/bots/recipes/swar...
> > > infra/bots/recipes/swarm_ct_skps.py:154: isolate_dir =
> > infrabots_dir.join('ct')
> > > On 2016/08/09 17:10:21, borenet wrote:
> > > > isolate_dir is already defined above, shouldn't have to do it again
here.
> > > 
> > > Done.
> > 
> > LGTM ::tremble::
> 
> Submitting this should have no change till builders in builder.cfg are moved
> over to use the default recipe?

Yep!

[rmistry, 2016-08-09 20:22:01]

The CQ bit was checked by rmistry@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 20:22:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 20:41:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 20:41:03]

Dry run: This issue passed the CQ dry run.

[rmistry, 2016-08-09 20:44:50]

The CQ bit was checked by rmistry@google.com

[commit-bot: I haz the power, 2016-08-09 20:45:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 20:46:51]

Description was changed from

==========
Move ct_skps recipe from tools repo to Skia repo.
Also move the isolate file and script from Chromium repo to the Skia repo.

BUG=skia:5620
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2221413002
==========

to

==========
Move ct_skps recipe from tools repo to Skia repo.
Also move the isolate file and script from Chromium repo to the Skia repo.

BUG=skia:5620
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2221413002

Committed:
https://skia.googlesource.com/skia/+/5eab99183c5dd74e24176daef8f742d61a7aeab3
==========

[commit-bot: I haz the power, 2016-08-09 20:46:52]

Committed patchset #3 (id:50001) as
https://skia.googlesource.com/skia/+/5eab99183c5dd74e24176daef8f742d61a7aeab3