Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issue 2221403002: base: Move all stl utilities to the base namespace (Closed)

Created:
4 years, 4 months ago by Sami
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: Move all stl utilities to the base namespace Previously only some of the utility functions in base/stl_util.h were in the base namespace. This patch moves all of them into that namespace. Since there are many call sites for these functions expecting them in the global namespace, this patch also adds transitionary aliases which will be removed once the call sites have been updated. Committed: https://crrev.com/68be7151416dcfc5e5a1aed66c6a76ef289f0ad1 Cr-Commit-Position: refs/heads/master@{#410851}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M base/stl_util.h View 3 chunks +18 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Sami
4 years, 4 months ago (2016-08-09 16:38:16 UTC) #3
Lei Zhang
They may have been left out of base:: intentionally. The google3 version is also in ...
4 years, 4 months ago (2016-08-09 17:49:52 UTC) #4
Lei Zhang
lgtm Side discussion regarding polluting the global namespace ended with no other good solutions, so ...
4 years, 4 months ago (2016-08-09 18:37:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2221403002/1
4 years, 4 months ago (2016-08-09 18:39:09 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 22:18:17 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 22:21:05 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/68be7151416dcfc5e5a1aed66c6a76ef289f0ad1
Cr-Commit-Position: refs/heads/master@{#410851}

Powered by Google App Engine
This is Rietveld 408576698