Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 2221363002: [turbofan] Do not rename context for loop exits in bytecode graph builder. (Closed)

Created:
4 years, 4 months ago by Jarin
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Do not rename context for loop exits in bytecode graph builder. Renaming context confuses specialization passes. (And looking through loop exit renames does not help because we insert Phis for SSA.) BUG=chromium:635808 Committed: https://crrev.com/ca9ec36eb5881f73c1ac1b5a5df710227ad96fae Cr-Commit-Position: refs/heads/master@{#38517}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Jarin
Could you take a look, please?
4 years, 4 months ago (2016-08-09 13:51:34 UTC) #5
Benedikt Meurer
lgtm
4 years, 4 months ago (2016-08-09 14:10:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2221363002/1
4 years, 4 months ago (2016-08-10 06:49:34 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 06:51:15 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 06:51:31 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca9ec36eb5881f73c1ac1b5a5df710227ad96fae
Cr-Commit-Position: refs/heads/master@{#38517}

Powered by Google App Engine
This is Rietveld 408576698