Bluetooth: mac: Crash while loging nil error.

device/bluetooth/bluetooth_low_energy_device_mac.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/bluetooth/bluetooth_low_energy_device_mac.h"
 
 #import <CoreFoundation/CoreFoundation.h>
 #include <stddef.h>
 
 #include "base/mac/mac_util.h"
@@ skipping 373 matching lines @@
        it != gatt_services_.end(); ++it) {
     device::BluetoothRemoteGattService* gatt_service = it->second;
     device::BluetoothRemoteGattServiceMac* gatt_service_mac =
         static_cast<BluetoothRemoteGattServiceMac*>(gatt_service);
     if (gatt_service_mac->GetService() == cb_service)
       return gatt_service_mac;
   }
   return nullptr;
 }
 
+void BluetoothLowEnergyDeviceMac::DidDisconnectPeripheral() {
+  RemoveAllServices();
+  DCHECK(create_gatt_connection_error_callbacks_.empty());
+  DidDisconnectGatt();
+}
+
 void BluetoothLowEnergyDeviceMac::DidDisconnectPeripheral(

[ortuno, 2016/08/09 19:14:56]

I wonder if we really need this function now. Once a device disconnects there
isn't much we need to do besides logging. Maybe we can just keep the non-error
version of the function.

[jlebel, 2016/08/10 08:42:19]

There is no point to call BluetoothDevice::DidDisconnectGatt()?

[ortuno, 2016/08/10 16:49:09]

I'm saying that you don't really need this error variant of the function because
you don't do anything with the error. So you can just delete this function and
always call the other one.

     BluetoothDevice::ConnectErrorCode error_code) {
+  RemoveAllServices();
+  DCHECK(create_gatt_connection_error_callbacks_.empty());
+  // TODO(http://crbug.com/585897): Need to pass the error.
+  DidDisconnectGatt();
+}
+
+void BluetoothLowEnergyDeviceMac::RemoveAllServices() {
   SetGattServicesDiscoveryComplete(false);
   // Removing all services at once to ensure that calling GetGattService on
   // removed service in GattServiceRemoved returns null.
   GattServiceMap gatt_services_swapped;
   gatt_services_swapped.swap(gatt_services_);
   gatt_services_swapped.clear();
-  if (create_gatt_connection_error_callbacks_.empty()) {
-    // TODO(http://crbug.com/585897): Need to pass the error.
-    DidDisconnectGatt();
-  } else {
-    DidFailToConnectGatt(error_code);
-  }
 }