Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2221343002: Revert "Track thread activities in order to diagnose hangs." (Closed)

Created:
4 years, 4 months ago by foolip
Modified:
4 years, 4 months ago
Reviewers:
bcwhite
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Track thread activities in order to diagnose hangs." This reverts commit 5d3470e5a33aaad936e171bee625b6b978ee3c34. This is the likely cause of MultiProfileFileManagerBrowserTest.PRE_BasicDrive becoming flaky. (Manual revert, CL was too big for revert button.) BUG=635832, 620813 TBR=bcwhite@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/b3655198b775c54da3170736a62f48b0f7964fb9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2266 lines) Patch
M base/BUILD.gn View 2 chunks +0 lines, -6 lines 0 comments Download
M base/base.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M base/base.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
D base/debug/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D base/debug/activity_analyzer.h View 1 chunk +0 lines, -159 lines 0 comments Download
D base/debug/activity_analyzer.cc View 1 chunk +0 lines, -129 lines 0 comments Download
D base/debug/activity_analyzer_unittest.cc View 1 chunk +0 lines, -181 lines 0 comments Download
D base/debug/activity_tracker.h View 1 chunk +0 lines, -608 lines 0 comments Download
D base/debug/activity_tracker.cc View 1 chunk +0 lines, -780 lines 0 comments Download
D base/debug/activity_tracker_unittest.cc View 1 chunk +0 lines, -298 lines 0 comments Download
M base/debug/task_annotator.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M base/process/process_posix.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M base/process/process_win.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M base/synchronization/lock_impl_posix.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M base/synchronization/lock_impl_win.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M base/synchronization/waitable_event_posix.cc View 3 chunks +0 lines, -7 lines 0 comments Download
M base/synchronization/waitable_event_win.cc View 4 chunks +0 lines, -12 lines 0 comments Download
M base/threading/platform_thread_posix.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M base/threading/platform_thread_win.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/chrome_browser_field_trials_desktop.cc View 3 chunks +0 lines, -31 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b3655198b775c54da3170736a62f48b0f7964fb9 Cr-Commit-Position: refs/heads/master@{#410635}
4 years, 4 months ago (2016-08-09 11:51:57 UTC) #2
foolip
Committed patchset #1 (id:1) manually as b3655198b775c54da3170736a62f48b0f7964fb9 (presubmit successful).
4 years, 4 months ago (2016-08-09 11:53:01 UTC) #4
bcwhite
4 years, 4 months ago (2016-08-09 15:58:40 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698