Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: components/offline_pages/background/request_queue_in_memory_store.cc

Issue 2221323003: Add an API to Pause and Resume background offlining requests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR feedback per Dimich Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_queue_in_memory_store.cc
diff --git a/components/offline_pages/background/request_queue_in_memory_store.cc b/components/offline_pages/background/request_queue_in_memory_store.cc
index 32219a91616eef459ea08ab4fb7116258f781355..e2622f9f288d7d5c65fcb80cc1500e1c6ca13a01 100644
--- a/components/offline_pages/background/request_queue_in_memory_store.cc
+++ b/components/offline_pages/background/request_queue_in_memory_store.cc
@@ -4,6 +4,7 @@
#include "components/offline_pages/background/request_queue_in_memory_store.h"
+#include <algorithm>
#include <set>
#include "base/bind.h"
@@ -73,6 +74,32 @@ void RequestQueueInMemoryStore::RemoveRequestsByClientId(
FROM_HERE, base::Bind(callback, true, count));
}
+void RequestQueueInMemoryStore::ChangeRequestsState(
+ const std::vector<int64_t>& request_ids,
+ const SavePageRequest::RequestState new_state,
+ const UpdateCallback& callback) {
+ int count = 0;
+
+ for (int64_t request_id : request_ids) {
+ auto pair = std::find_if(
+ requests_.begin(), requests_.end(),
fgorski 2016/08/10 16:00:09 I don't think lambda is necessary here, as you we
Pete Williamson 2016/08/10 21:38:00 Ah, good catch, I totally forgot what the map was
+ [request_id](
+ std::pair<const long, offline_pages::SavePageRequest> pair) {
+ return (request_id == pair.second.request_id());
+ });
+ if (pair != requests_.end()) {
+ ++count;
+ pair->second.set_request_state(new_state);
+ }
+ }
+
+ RequestQueueStore::UpdateStatus status =
+ count > 0 ? UpdateStatus::UPDATED : UpdateStatus::FAILED;
fgorski 2016/08/10 16:00:09 what if there were no items? Makes me think that o
Pete Williamson 2016/08/10 21:38:00 Done.
+
+ base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
+ base::Bind(callback, status));
+}
+
void RequestQueueInMemoryStore::Reset(const ResetCallback& callback) {
requests_.clear();
base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,

Powered by Google App Engine
This is Rietveld 408576698