Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: components/offline_pages/background/request_queue_store_sql.h

Issue 2221323003: Add an API to Pause and Resume background offlining requests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR feedback per Dimich Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_QUEUE_STORE_SQL_H_ 5 #ifndef COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_QUEUE_STORE_SQL_H_
6 #define COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_QUEUE_STORE_SQL_H_ 6 #define COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_QUEUE_STORE_SQL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 16 matching lines...) Expand all
27 // SQLite implementation of RequestQueueStore. 27 // SQLite implementation of RequestQueueStore.
28 class RequestQueueStoreSQL : public RequestQueueStore { 28 class RequestQueueStoreSQL : public RequestQueueStore {
29 public: 29 public:
30 RequestQueueStoreSQL( 30 RequestQueueStoreSQL(
31 scoped_refptr<base::SequencedTaskRunner> background_task_runner, 31 scoped_refptr<base::SequencedTaskRunner> background_task_runner,
32 const base::FilePath& database_dir); 32 const base::FilePath& database_dir);
33 ~RequestQueueStoreSQL() override; 33 ~RequestQueueStoreSQL() override;
34 34
35 // RequestQueueStore implementation. 35 // RequestQueueStore implementation.
36 void GetRequests(const GetRequestsCallback& callback) override; 36 void GetRequests(const GetRequestsCallback& callback) override;
37
fgorski 2016/08/10 16:00:09 nit: same comment for this and next empty line as
Pete Williamson 2016/08/10 21:38:01 Done.
37 void AddOrUpdateRequest(const SavePageRequest& offline_page, 38 void AddOrUpdateRequest(const SavePageRequest& offline_page,
38 const UpdateCallback& callback) override; 39 const UpdateCallback& callback) override;
39 void RemoveRequests(const std::vector<int64_t>& request_ids, 40 void RemoveRequests(const std::vector<int64_t>& request_ids,
40 const RemoveCallback& callback) override; 41 const RemoveCallback& callback) override;
41 void RemoveRequestsByClientId(const std::vector<ClientId>& client_ids, 42 void RemoveRequestsByClientId(const std::vector<ClientId>& client_ids,
42 const RemoveCallback& callback) override; 43 const RemoveCallback& callback) override;
44
45 void ChangeRequestsState(const std::vector<int64_t>& request_ids,
46 const SavePageRequest::RequestState new_state,
47 const UpdateCallback& callback) override;
48
43 void Reset(const ResetCallback& callback) override; 49 void Reset(const ResetCallback& callback) override;
44 50
45 private: 51 private:
46 // Synchronous implementations, these are run on the background thread 52 // Synchronous implementations, these are run on the background thread
47 // and actually do the work to access SQL. The implementations above 53 // and actually do the work to access SQL. The implementations above
48 // simply dispatch to the corresponding *Sync method on the background thread. 54 // simply dispatch to the corresponding *Sync method on the background thread.
49 // 'runner' is where to run the callback. 55 // 'runner' is where to run the callback.
50 static void GetRequestsSync( 56 static void GetRequestsSync(
51 sql::Connection* db, 57 sql::Connection* db,
52 scoped_refptr<base::SingleThreadTaskRunner> runner, 58 scoped_refptr<base::SingleThreadTaskRunner> runner,
53 const GetRequestsCallback& callback); 59 const GetRequestsCallback& callback);
54 static void AddOrUpdateRequestSync( 60 static void AddOrUpdateRequestSync(
55 sql::Connection* db, 61 sql::Connection* db,
56 scoped_refptr<base::SingleThreadTaskRunner> runner, 62 scoped_refptr<base::SingleThreadTaskRunner> runner,
57 const SavePageRequest& offline_page, 63 const SavePageRequest& offline_page,
58 const UpdateCallback& callback); 64 const UpdateCallback& callback);
59 static void RemoveRequestsSync( 65 static void RemoveRequestsSync(
60 sql::Connection* db, 66 sql::Connection* db,
61 scoped_refptr<base::SingleThreadTaskRunner> runner, 67 scoped_refptr<base::SingleThreadTaskRunner> runner,
62 const std::vector<int64_t>& request_ids, 68 const std::vector<int64_t>& request_ids,
63 const RemoveCallback& callback); 69 const RemoveCallback& callback);
64 static void RemoveRequestsByClientIdSync( 70 static void RemoveRequestsByClientIdSync(
65 sql::Connection* db, 71 sql::Connection* db,
66 scoped_refptr<base::SingleThreadTaskRunner> runner, 72 scoped_refptr<base::SingleThreadTaskRunner> runner,
67 const std::vector<ClientId>& client_ids, 73 const std::vector<ClientId>& client_ids,
68 const RemoveCallback& callback); 74 const RemoveCallback& callback);
75 static void ChangeRequestsStateSync(
76 sql::Connection* db,
77 scoped_refptr<base::SingleThreadTaskRunner> runner,
78 const std::vector<int64_t>& request_ids,
79 const SavePageRequest::RequestState new_state,
80 const UpdateCallback& callback);
69 static void ResetSync(sql::Connection* db, 81 static void ResetSync(sql::Connection* db,
70 const base::FilePath& db_file_path, 82 const base::FilePath& db_file_path,
71 scoped_refptr<base::SingleThreadTaskRunner> runner, 83 scoped_refptr<base::SingleThreadTaskRunner> runner,
72 const ResetCallback& callback); 84 const ResetCallback& callback);
73 85
86 // Helper functions to return immediately if no database is found.
87 bool CheckDb(const base::Closure& callback);
88
74 // Used to initialize DB connection. 89 // Used to initialize DB connection.
75 static void OpenConnectionSync( 90 static void OpenConnectionSync(
76 sql::Connection* db, 91 sql::Connection* db,
77 scoped_refptr<base::SingleThreadTaskRunner> runner, 92 scoped_refptr<base::SingleThreadTaskRunner> runner,
78 const base::FilePath& path, 93 const base::FilePath& path,
79 const base::Callback<void(bool)>& callback); 94 const base::Callback<void(bool)>& callback);
80 void OpenConnection(); 95 void OpenConnection();
81 void OnOpenConnectionDone(bool success); 96 void OnOpenConnectionDone(bool success);
82 97
83 // Used to finalize connection reset. 98 // Used to finalize connection reset.
84 void OnResetDone(const ResetCallback& callback, bool success); 99 void OnResetDone(const ResetCallback& callback, bool success);
85 100
86 // Background thread where all SQL access should be run. 101 // Background thread where all SQL access should be run.
87 scoped_refptr<base::SequencedTaskRunner> background_task_runner_; 102 scoped_refptr<base::SequencedTaskRunner> background_task_runner_;
88 103
89 // Path to the database on disk. 104 // Path to the database on disk.
90 base::FilePath db_file_path_; 105 base::FilePath db_file_path_;
91 106
92 // Database connection. 107 // Database connection.
93 std::unique_ptr<sql::Connection> db_; 108 std::unique_ptr<sql::Connection> db_;
94 109
95 base::WeakPtrFactory<RequestQueueStoreSQL> weak_ptr_factory_; 110 base::WeakPtrFactory<RequestQueueStoreSQL> weak_ptr_factory_;
96 DISALLOW_COPY_AND_ASSIGN(RequestQueueStoreSQL); 111 DISALLOW_COPY_AND_ASSIGN(RequestQueueStoreSQL);
97 }; 112 };
98 113
99 } // namespace offline_pages 114 } // namespace offline_pages
100 115
101 #endif // COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_QUEUE_STORE_SQL_H_ 116 #endif // COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_QUEUE_STORE_SQL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698