Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2221323002: X87: [turbofan] Make Float32Neg and Float64Neg mandatory operators. (Closed)

Created:
4 years, 4 months ago by zhengxing.li
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Make Float32Neg and Float64Neg mandatory operators. port 6c44ab30fd6a74dd4a334b8d9ccc370bc1591d75 (r38399) original commit message: BUG= Committed: https://crrev.com/8f0ff8f821cb87d8ad472772b42caa0ebab782b8 Cr-Commit-Position: refs/heads/master@{#38476}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 4 months ago (2016-08-09 07:37:46 UTC) #2
Weiliang
lgtm
4 years, 4 months ago (2016-08-09 07:38:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2221323002/1
4 years, 4 months ago (2016-08-09 07:39:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 08:06:14 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 08:07:07 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8f0ff8f821cb87d8ad472772b42caa0ebab782b8
Cr-Commit-Position: refs/heads/master@{#38476}

Powered by Google App Engine
This is Rietveld 408576698