Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 2221303002: Simplify WebNotificationTray (Closed)

Created:
4 years, 4 months ago by mohsen
Modified:
4 years, 4 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify WebNotificationTray Despite being an ActionableView, WebNotificationTray unnecessarily hosts a button and calls its ActionableView::PerformAction() from its ButtonListener::ButtonPressed(). We can get rid of the button and let the ActionableView handle the clicks on the item. This is a step forward to enable ink drop ripples on WebNotificationTray. BUG=612579 TEST=WebNotificaitonTrayTest.* Committed: https://crrev.com/d7064c4dc2482e763c1cdbe4281d66e064c70a75 Cr-Commit-Position: refs/heads/master@{#410756}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -35 lines) Patch
M ash/common/system/web_notification/web_notification_tray.h View 5 chunks +2 lines, -8 lines 0 comments Download
M ash/common/system/web_notification/web_notification_tray.cc View 1 10 chunks +12 lines, -27 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
mohsen
Please take a look...
4 years, 4 months ago (2016-08-09 05:04:25 UTC) #5
James Cook
LGTM. Nice patch. https://codereview.chromium.org/2221303002/diff/1/ash/common/system/web_notification/web_notification_tray.cc File ash/common/system/web_notification/web_notification_tray.cc (left): https://codereview.chromium.org/2221303002/diff/1/ash/common/system/web_notification/web_notification_tray.cc#oldcode488 ash/common/system/web_notification/web_notification_tray.cc:488: button_->SetState(views::CustomButton::STATE_PRESSED); I presume the calls to ...
4 years, 4 months ago (2016-08-09 16:15:43 UTC) #8
mohsen
Also, added a comment as to why border needs to be reset every time shelf ...
4 years, 4 months ago (2016-08-09 17:53:12 UTC) #9
James Cook
still lgtm. thanks.
4 years, 4 months ago (2016-08-09 18:19:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2221303002/20001
4 years, 4 months ago (2016-08-09 18:39:43 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-09 18:43:36 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 18:45:21 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d7064c4dc2482e763c1cdbe4281d66e064c70a75
Cr-Commit-Position: refs/heads/master@{#410756}

Powered by Google App Engine
This is Rietveld 408576698