Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2221283002:
Fix VirtualKeyboardTray border (Closed)
|
Created:
4 years, 4 months ago by mohsen Modified:
4 years, 4 months ago Reviewers:
James Cook CC:
chromium-reviews, kalyank, oshima+watch_chromium.org, sadrul Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix VirtualKeyboardTray border
We need to set a null border for VirtualKeyboardTray every time shelf
alignment changes. This was regressed in r410413 which simplified
VirtualKeyboardTray's View hierarchy.
BUG=635706
TEST=none
Committed: https://crrev.com/e174a0faee78a356b775b16a1444f52d1dd319e5
Cr-Commit-Position: refs/heads/master@{#410736}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Added a comment #Messages
Total messages: 18 (11 generated)
The CQ bit was checked by mohsen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
mohsen@chromium.org changed reviewers: + jamescook@chromium.org
Please take a look...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2221283002/diff/1/ash/common/system/chromeos/... File ash/common/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc (right): https://codereview.chromium.org/2221283002/diff/1/ash/common/system/chromeos/... ash/common/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc:101: tray_container()->SetBorder(views::Border::NullBorder()); Why does this have to be done every time the shelf alignment changes? If it can't just be done once, can you add a comment here explaining why it has to be done each time?
https://codereview.chromium.org/2221283002/diff/1/ash/common/system/chromeos/... File ash/common/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc (right): https://codereview.chromium.org/2221283002/diff/1/ash/common/system/chromeos/... ash/common/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc:101: tray_container()->SetBorder(views::Border::NullBorder()); On 2016/08/09 at 15:54:32, James Cook wrote: > Why does this have to be done every time the shelf alignment changes? If it can't just be done once, can you add a comment here explaining why it has to be done each time? After each shelf alignment change, the border is reset (see StatusAreaWidgetDelegate::SetBorderOnChild()). Added a comment.
The CQ bit was checked by mohsen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM. Thanks for the quick fix!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mohsen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix VirtualKeyboardTray border We need to set a null border for VirtualKeyboardTray every time shelf alignment changes. This was regressed in r410413 which simplified VirtualKeyboardTray's View hierarchy. BUG=635706 TEST=none ========== to ========== Fix VirtualKeyboardTray border We need to set a null border for VirtualKeyboardTray every time shelf alignment changes. This was regressed in r410413 which simplified VirtualKeyboardTray's View hierarchy. BUG=635706 TEST=none Committed: https://crrev.com/e174a0faee78a356b775b16a1444f52d1dd319e5 Cr-Commit-Position: refs/heads/master@{#410736} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/e174a0faee78a356b775b16a1444f52d1dd319e5 Cr-Commit-Position: refs/heads/master@{#410736} |
