dart2js: Sort libraries by Uri only.

dart2js: Sort libraries by Uri only.

Avoid using the 'library' tag.

Remove compareTo method from CompilationUnitElement and LibraryElement.

BUG=
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/b6f84a01d61322238c6b989f50321649425150e5

[sra1, 2016-08-09 20:54:41]

Patchset #1 (id:1) has been deleted

[sra1, 2016-08-09 21:31:58]

Patchset #1 (id:20001) has been deleted

[sra1, 2016-08-09 21:46:02]

Description was changed from

==========
dart2js: Sort libraries by Uri only.

Avoid using the 'library' tag.
BUG=
==========

to

==========
dart2js: Sort libraries by Uri only.

Avoid using the 'library' tag.

Remove compareTo method from CompilationUnitElement and LibraryElement.

BUG=
==========

[sra1, 2016-08-09 21:46:02]

sra@google.com changed reviewers:
+ sigmund@google.com

[sra1, 2016-08-09 21:48:29]

If it turns out later that we need some contextual information for a stable
ordering, I will refactor the 'compare' methods to be methods of a global
'ElementOrdering' object that can access the contextual information.

[sra1, 2016-08-09 21:49:47]

In addition to decoupling one use of the frontend from the backend, not using
the library tag seems to speed up some compilations by 2%

[Siggi Cherem (dart-lang), 2016-08-09 22:11:22]

LGTM! 

whohoo on the 2% - I'm not surprised it was expensive (we had this show up on
the perf profiles before), but it's great to see it improve!

https://codereview.chromium.org/2221273002/diff/40001/pkg/compiler/lib/src/el...
File pkg/compiler/lib/src/elements/elements.dart (right):

https://codereview.chromium.org/2221273002/diff/40001/pkg/compiler/lib/src/el...
pkg/compiler/lib/src/elements/elements.dart:739: // We would like the order of
'file:' Uris to be stable across different
Can we add an extra rule here that if scheme == file &&
path.startsWith('/bazel-root/') then we do the canonical path sort?

It might be worth noting that we can later provide the bazel-root paths even
when working in temp directories as long as we provide a small bazel-config
flag, so we can preserve the same order even if you copy code from bazel out of
bazel.

https://codereview.chromium.org/2221273002/diff/40001/pkg/compiler/lib/src/el...
pkg/compiler/lib/src/elements/elements.dart:990: //int compareTo(LibraryElement
other);
delete?

[sra1, 2016-08-11 00:09:38]

Description was changed from

==========
dart2js: Sort libraries by Uri only.

Avoid using the 'library' tag.

Remove compareTo method from CompilationUnitElement and LibraryElement.

BUG=
==========

to

==========
dart2js: Sort libraries by Uri only.

Avoid using the 'library' tag.

Remove compareTo method from CompilationUnitElement and LibraryElement.

BUG=
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b6f84a01d61322238c6b989f50321649425150e5
==========

[sra1, 2016-08-11 00:09:39]

Committed patchset #1 (id:40001) manually as
b6f84a01d61322238c6b989f50321649425150e5 (presubmit successful).