fix #27036, pass definite function types to LUB

fix #27036, pass definite function types to LUB

R=vsm@google.com

Committed: https://github.com/dart-lang/sdk/commit/9242687547e8fce046ad253f93100486bd8cdbc0

[Jennifer Messerly, 2016-08-08 23:51:26]

jmesserly@google.com changed reviewers:
+ leafp@google.com, vsm@google.com

[Jennifer Messerly, 2016-08-08 23:51:27]

BTW, I think this is a slightly more pervasive problem, as described here:
https://github.com/dart-lang/sdk/issues/27036#issuecomment-238302937

That said, we're working around it in most places already by explicitly asking
for the definite type.

https://codereview.chromium.org/2221233002/diff/20001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/static_type_analyzer.dart (right):

https://codereview.chromium.org/2221233002/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/static_type_analyzer.dart:2013: void
_inferLocalFunctionReturnType(FunctionExpression node) {
sorting :\

[Jennifer Messerly, 2016-08-08 23:52:34]

On 2016/08/08 23:51:27, John Messerly wrote:
> BTW, I think this is a slightly more pervasive problem, as described here:
> https://github.com/dart-lang/sdk/issues/27036#issuecomment-238302937
> 
> That said, we're working around it in most places already by explicitly asking
> for the definite type.
> 
>
https://codereview.chromium.org/2221233002/diff/20001/pkg/analyzer/lib/src/ge...
> File pkg/analyzer/lib/src/generated/static_type_analyzer.dart (right):
> 
>
https://codereview.chromium.org/2221233002/diff/20001/pkg/analyzer/lib/src/ge...
> pkg/analyzer/lib/src/generated/static_type_analyzer.dart:2013: void
> _inferLocalFunctionReturnType(FunctionExpression node) {
> sorting :\

BTW, Paul hit this merging Analyzer into internal code. Hence my trying to
address it more quickly. It got exposed because we fixed a soundness hole in LUB
:)

[Jennifer Messerly, 2016-08-09 12:35:19]

https://codereview.chromium.org/2221233002/diff/40001/pkg/analyzer/lib/src/ta...
File pkg/analyzer/lib/src/task/strong/checker.dart (right):

https://codereview.chromium.org/2221233002/diff/40001/pkg/analyzer/lib/src/ta...
pkg/analyzer/lib/src/task/strong/checker.dart:211: void
checkFunctionApplication(InvocationExpression node) {
fyi -- I did a small refactor in patch set 2, taking advantage of
InvocationExpression to treat things more uniformly.

It might be a slight fix as well for calls to generic functions via
FunctionInvocationExpressions (which doesn't come up much, but if it did...)

[Jennifer Messerly, 2016-08-10 15:29:45]

Friendly ping :)

[vsm, 2016-08-10 21:22:21]

lgtm

https://codereview.chromium.org/2221233002/diff/40001/pkg/analyzer/lib/src/ta...
File pkg/analyzer/lib/src/task/strong/checker.dart (right):

https://codereview.chromium.org/2221233002/diff/40001/pkg/analyzer/lib/src/ta...
pkg/analyzer/lib/src/task/strong/checker.dart:994: DartType
_getStaticType(Expression expr) =>
Maybe rename to _getDefiniteType?

The terminology between here and static_type_analyzer seems inconsistent - there
getStaticType returns the fuzzy one.

[Jennifer Messerly, 2016-08-10 22:28:09]

thanks!

https://codereview.chromium.org/2221233002/diff/40001/pkg/analyzer/lib/src/ta...
File pkg/analyzer/lib/src/task/strong/checker.dart (right):

https://codereview.chromium.org/2221233002/diff/40001/pkg/analyzer/lib/src/ta...
pkg/analyzer/lib/src/task/strong/checker.dart:994: DartType
_getStaticType(Expression expr) =>
On 2016/08/10 21:22:21, vsm wrote:
> Maybe rename to _getDefiniteType?
> 
> The terminology between here and static_type_analyzer seems inconsistent -
there
> getStaticType returns the fuzzy one.  

good catch. Done!

[Jennifer Messerly, 2016-08-10 22:29:55]

Description was changed from

==========
fix #27036, pass definite function types to LUB
==========

to

==========
fix #27036, pass definite function types to LUB

R=vsm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9242687547e8fce046ad253f93100486bd8cdbc0
==========

[Jennifer Messerly, 2016-08-10 22:29:57]

Committed patchset #4 (id:60001) manually as
9242687547e8fce046ad253f93100486bd8cdbc0 (presubmit successful).