Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 222123003: Parser cleanup: PreParser doesn't need to produce symbol data any more. (Closed)

Created:
6 years, 8 months ago by marja
Modified:
6 years, 8 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Parser cleanup: PreParser doesn't need to produce symbol data any more. State of the art: - Chromium doesn't do a separate preparsing phase any more. - We start parsing with Parser, and when it sees a lazy function, it falls back to PreParser for that function. - The symbol data should contain symbols which are *outside* lazy functions. - So Parser should always produce symbol data, and PreParser should never. - Because it's this simple now, we don't need to keep track of "should produce symbol data" (i.e., whether we're inside a lazy func or not). R=ulan@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20707

Patch Set 1 #

Patch Set 2 : test fix #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -44 lines) Patch
M src/parser.cc View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M src/preparse-data.h View 4 chunks +1 line, -18 lines 0 comments Download
M src/preparse-data.cc View 4 chunks +0 lines, -4 lines 0 comments Download
M src/preparser.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/preparser.cc View 4 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
marja
ulan, ptal
6 years, 8 months ago (2014-04-03 16:57:03 UTC) #1
marja
ulan, ptal
6 years, 8 months ago (2014-04-03 16:57:04 UTC) #2
marja
(uploaded test fix; state of hubris now less)
6 years, 8 months ago (2014-04-03 17:31:30 UTC) #3
marja
Meh, I'll restructure this a bit, I'll make another CL for just updating the tests ...
6 years, 8 months ago (2014-04-04 07:46:07 UTC) #4
marja
ulan, I did the test update & other cleanups (preparser API removal) in another CLs, ...
6 years, 8 months ago (2014-04-14 07:48:02 UTC) #5
ulan
lgtm
6 years, 8 months ago (2014-04-14 08:18:43 UTC) #6
marja
6 years, 8 months ago (2014-04-14 08:49:39 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r20707 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698