Updates on canvas backreference for canvas rendering contexts

Updates on canvas backreference on canvas rendering contexts

Based on recent proposal (https://wiki.whatwg.org/wiki/OffscreenCanvas) change,
the backreference to either html canvas or offscreen canvas should be named as
"canvas" consistently for all rendering contexts.

This CL changes the the different name "offscreencanvas" in
OffscreenCanvasRenderingContext2D. Also, this CL allows Webgl rendering contexts
that are created from OffscreenCanvas to return the OffscreenCanvas, and those
that are created from HTMLCanvas to return the HTMLCanvasElement, via the same
"canvas" attribute.

BUG=637022
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/903a3a827ddbf8dc46ada202c6768a997860c7bf
Cr-Commit-Position: refs/heads/master@{#411444}

[xlai (Olivia), 2016-08-08 20:31:45]

Description was changed from

==========
Updates on canvas backreference on canvas rendering contexts

Based on recent proposal (https://wiki.whatwg.org/wiki/OffscreenCanvas) change,
the backreference to canvas should be named as canvas for consistency with other
rendering contexts.

Also, this should be a read-only attribute.

BUG=None
==========

to

==========
Updates on canvas backreference on canvas rendering contexts

Based on recent proposal (https://wiki.whatwg.org/wiki/OffscreenCanvas) change,
the backreference to canvas should be named as canvas for consistency with other
rendering contexts.

Also, this should be a read-only attribute.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[xlai (Olivia), 2016-08-08 20:33:57]

xlai@chromium.org changed reviewers:
+ junov@chromium.org, kbr@chromium.org

[xlai (Olivia), 2016-08-08 20:33:58]

junov@chromium.org: Please review changes in CanvasRenderingContext2D and
OffscreenCanvasRenderingContext2D.idl

kbr@chromium.org: Please review changes in WebGLRenderingContextBase.idl

Thanks!

[xlai (Olivia), 2016-08-08 20:40:40]

Description was changed from

==========
Updates on canvas backreference on canvas rendering contexts

Based on recent proposal (https://wiki.whatwg.org/wiki/OffscreenCanvas) change,
the backreference to canvas should be named as canvas for consistency with other
rendering contexts.

Also, this should be a read-only attribute.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Updates on canvas backreference on canvas rendering contexts

Based on recent proposal (https://wiki.whatwg.org/wiki/OffscreenCanvas) change,
the backreference to canvas should be named as canvas for consistency with other
rendering contexts.


BUG=None
==========

[xlai (Olivia), 2016-08-08 20:40:40]

xlai@chromium.org changed reviewers:
- kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-08-08 20:56:43]

kbr@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-08-08 20:56:44]

Not seeing WebGL-related changes in the current patch set.

[xlai (Olivia), 2016-08-08 21:11:18]

On 2016/08/08 20:56:44, Ken Russell wrote:
> Not seeing WebGL-related changes in the current patch set.

Sorry, after sending out the email I realize that the "canvas" attribute on all
the rendering contexts are already marked as "readonly".

[Justin Novosad, 2016-08-09 14:38:35]

Hmmm. No tests needed to be updated as a result of this change?  Then we should
add a test.

[xlai (Olivia), 2016-08-09 17:43:34]

test added

[Justin Novosad, 2016-08-09 20:26:46]

On 2016/08/09 17:43:34, xlai (Olivia) wrote:
> test added

Could you refactor it to use "generate_tests" to avoid the copy/pasted function
bodies.

could you also add cases for 
a) a "bitmaprenderer" context
b) a webgl context created from an OffscreenCanvas

[xlai (Olivia), 2016-08-09 22:11:08]

On 2016/08/09 20:26:46, Justin Novosad wrote:
> On 2016/08/09 17:43:34, xlai (Olivia) wrote:
> > test added
> 
> Could you refactor it to use "generate_tests" to avoid the copy/pasted
function
> bodies.
> 
> could you also add cases for 
> a) a "bitmaprenderer" context
> b) a webgl context created from an OffscreenCanvas

I did some modification including adding generate_tests function and adding one
small test for bitmaprenderer context.

But I didn't add test for webglcontext created from OffscreenCanvas, as I
realize that webgl context does not have a
user-exposed function that reference back to OffscreenCanvas. As both Offscreen
and HTML webgl contexts share the IDL
file, if they want to use the same function name canvas() to return either
OffscreenCanvas or HTMLCanvasElement, I need
to do some modification in webgl IDL and code to re-implement the canvas()
function, do you want me to do that?

[Ken Russell (switch to Gerrit), 2016-08-09 22:25:50]

On 2016/08/09 22:11:08, xlai (Olivia) wrote:
> On 2016/08/09 20:26:46, Justin Novosad wrote:
> > On 2016/08/09 17:43:34, xlai (Olivia) wrote:
> > > test added
> > 
> > Could you refactor it to use "generate_tests" to avoid the copy/pasted
> function
> > bodies.
> > 
> > could you also add cases for 
> > a) a "bitmaprenderer" context
> > b) a webgl context created from an OffscreenCanvas
> 
> I did some modification including adding generate_tests function and adding
one
> small test for bitmaprenderer context.
> 
> But I didn't add test for webglcontext created from OffscreenCanvas, as I
> realize that webgl context does not have a
> user-exposed function that reference back to OffscreenCanvas. As both
Offscreen
> and HTML webgl contexts share the IDL
> file, if they want to use the same function name canvas() to return either
> OffscreenCanvas or HTMLCanvasElement, I need
> to do some modification in webgl IDL and code to re-implement the canvas()
> function, do you want me to do that?

WebGLRenderingContextBase.idl contains:
"readonly attribute HTMLCanvasElement canvas;"

which should presumably be generalized to return a union type of either an
HTMLCanvasElement or OffscreenCanvas. Does that sound like the right approach?

[xlai (Olivia), 2016-08-10 16:37:47]

Description was changed from

==========
Updates on canvas backreference on canvas rendering contexts

Based on recent proposal (https://wiki.whatwg.org/wiki/OffscreenCanvas) change,
the backreference to canvas should be named as canvas for consistency with other
rendering contexts.


BUG=None
==========

to

==========
Updates on canvas backreference on canvas rendering contexts

Based on recent proposal (https://wiki.whatwg.org/wiki/OffscreenCanvas) change,
the backreference to canvas should be named as canvas for consistency with other
rendering contexts.


BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[xlai (Olivia), 2016-08-10 16:42:18]

xlai@chromium.org changed reviewers:
+ japhet@chromium.org

[xlai (Olivia), 2016-08-10 16:42:19]

japhet@chromium.org: Please review changes in Source/bindings/modules/v8.

kbr@chromium.org: Please review changes in Source/modules/webgl/. Based on your
previous suggestion, I unify the canvas attribute on Webgl rendering context to
return either HTML canvas or Offscreen canvas, in the latest patch.

Thanks!

[Ken Russell (switch to Gerrit), 2016-08-10 18:52:34]

Excellent! LGTM.

[Justin Novosad, 2016-08-10 18:56:33]

https://codereview.chromium.org/2221173003/diff/120001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/fast/canvas/rendering-contexts-back-references.html
(right):

https://codereview.chromium.org/2221173003/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/canvas/rendering-contexts-back-references.html:4:
function generateTest(canvas, context, anotherCanvas, message)
I meant use "generate_tests" from testharness.js instead of using "test" below.

[xlai (Olivia), 2016-08-10 20:51:29]

https://codereview.chromium.org/2221173003/diff/120001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/fast/canvas/rendering-contexts-back-references.html
(right):

https://codereview.chromium.org/2221173003/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/canvas/rendering-contexts-back-references.html:4:
function generateTest(canvas, context, anotherCanvas, message)
On 2016/08/10 18:56:33, Justin Novosad wrote:
> I meant use "generate_tests" from testharness.js instead of using "test"
below.

Done.

[Nate Chapin, 2016-08-10 21:22:15]

lgtm

[Justin Novosad, 2016-08-11 17:37:58]

https://codereview.chromium.org/2221173003/diff/140001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/fast/canvas/rendering-contexts-back-references.html
(right):

https://codereview.chromium.org/2221173003/diff/140001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/canvas/rendering-contexts-back-references.html:34:
generate_tests(test_back_ref, tests);
You are not using the test pattern optimally. The idea is to use generate_tests
in a way that maximizes readability and maintainability. Something like this
(untested code):

function make_canvas(type)
{
    if (type == "html")
        return document.createElement("canvas");
    return new OffscreenCanvas(10,10);
}

function test_back_ref(contextType, canvasType)
{
    var canvas = make_canvas(canvasType);
    var ctx = canvas.getContext(contextType);
    assert_equals(ctx.canvas, canvas, "Back reference works.");
    var anotherCanvas = make_canvas(canvasType);
    ctx.canvas = anotherCanvas;
    assert_not_equals(ctx.canvas, anotherCanvas, "Canvas attribute is read
only.");
}

generate_tests(test_back_ref, [
    ["2d context on html canvas",             "2d",             "html"],
    ["webgl context on html canvas",          "webgl",          "html"],
    ["bitmaprenderer context on html canvas", "bitmaprenderer", "html"],
    ["2d context on offscreen canvas",        "2d",             "offscreen"],
    ["webgl context on offscreen canvas",     "webgl",          "offscreen"],
]);

[xlai (Olivia), 2016-08-11 17:53:45]

Further simplified the layout test

[xlai (Olivia), 2016-08-11 17:53:46]

Further simplified the layout test

[Justin Novosad, 2016-08-11 17:57:14]

lgtm

https://codereview.chromium.org/2221173003/diff/160001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/fast/canvas/rendering-contexts-back-references.html
(right):

https://codereview.chromium.org/2221173003/diff/160001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/canvas/rendering-contexts-back-references.html:22:
["2d context on html canvas",             "2d",             "html"],
Nit: funky indent

[xlai (Olivia), 2016-08-11 18:13:10]

The CQ bit was checked by xlai@chromium.org

[xlai (Olivia), 2016-08-11 18:13:11]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
japhet@chromium.org, junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2221173003/#ps180001
(title: "Rebase master + indent nits")

[commit-bot: I haz the power, 2016-08-11 18:14:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xlai (Olivia), 2016-08-11 18:14:32]

Description was changed from

==========
Updates on canvas backreference on canvas rendering contexts

Based on recent proposal (https://wiki.whatwg.org/wiki/OffscreenCanvas) change,
the backreference to canvas should be named as canvas for consistency with other
rendering contexts.


BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Updates on canvas backreference on canvas rendering contexts

Based on recent proposal (https://wiki.whatwg.org/wiki/OffscreenCanvas) change,
the backreference to canvas should be named as canvas for consistency with other
rendering contexts.

Not only that, this CL unifies the canvas back reference on WebGL rendering
contexts so that it returns either HTMLCanvasElement or OffscreenCanvas
depending
on the situation.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[xlai (Olivia), 2016-08-11 18:33:19]

Description was changed from

==========
Updates on canvas backreference on canvas rendering contexts

Based on recent proposal (https://wiki.whatwg.org/wiki/OffscreenCanvas) change,
the backreference to canvas should be named as canvas for consistency with other
rendering contexts.

Not only that, this CL unifies the canvas back reference on WebGL rendering
contexts so that it returns either HTMLCanvasElement or OffscreenCanvas
depending
on the situation.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Updates on canvas backreference on canvas rendering contexts

Based on recent proposal (https://wiki.whatwg.org/wiki/OffscreenCanvas) change,
the backreference to either html canvas or offscreen canvas should be named as
"canvas" consistently for all rendering contexts.

This CL changes the the different name "offscreencanvas" in
OffscreenCanvasRenderingContext2D. Also, this CL allows Webgl rendering contexts
that are created from OffscreenCanvas to return the OffscreenCanvas, and those
that are created from HTMLCanvas to return the HTMLCanvasElement, via the same
"canvas" attribute.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[xlai (Olivia), 2016-08-11 18:35:31]

Description was changed from

==========
Updates on canvas backreference on canvas rendering contexts

Based on recent proposal (https://wiki.whatwg.org/wiki/OffscreenCanvas) change,
the backreference to either html canvas or offscreen canvas should be named as
"canvas" consistently for all rendering contexts.

This CL changes the the different name "offscreencanvas" in
OffscreenCanvasRenderingContext2D. Also, this CL allows Webgl rendering contexts
that are created from OffscreenCanvas to return the OffscreenCanvas, and those
that are created from HTMLCanvas to return the HTMLCanvasElement, via the same
"canvas" attribute.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Updates on canvas backreference on canvas rendering contexts

Based on recent proposal (https://wiki.whatwg.org/wiki/OffscreenCanvas) change,
the backreference to either html canvas or offscreen canvas should be named as
"canvas" consistently for all rendering contexts.

This CL changes the the different name "offscreencanvas" in
OffscreenCanvasRenderingContext2D. Also, this CL allows Webgl rendering contexts
that are created from OffscreenCanvas to return the OffscreenCanvas, and those
that are created from HTMLCanvas to return the HTMLCanvasElement, via the same
"canvas" attribute.

BUG=637022
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[xlai (Olivia), 2016-08-11 19:21:16]

The CQ bit was unchecked by xlai@chromium.org

[xlai (Olivia), 2016-08-11 19:24:51]

The CQ bit was checked by xlai@chromium.org

[xlai (Olivia), 2016-08-11 19:24:51]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
japhet@chromium.org, junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2221173003/#ps200001
(title: "Interface listing expected texts")

[commit-bot: I haz the power, 2016-08-11 19:25:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 23:39:48]

Description was changed from

==========
Updates on canvas backreference on canvas rendering contexts

Based on recent proposal (https://wiki.whatwg.org/wiki/OffscreenCanvas) change,
the backreference to either html canvas or offscreen canvas should be named as
"canvas" consistently for all rendering contexts.

This CL changes the the different name "offscreencanvas" in
OffscreenCanvasRenderingContext2D. Also, this CL allows Webgl rendering contexts
that are created from OffscreenCanvas to return the OffscreenCanvas, and those
that are created from HTMLCanvas to return the HTMLCanvasElement, via the same
"canvas" attribute.

BUG=637022
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Updates on canvas backreference on canvas rendering contexts

Based on recent proposal (https://wiki.whatwg.org/wiki/OffscreenCanvas) change,
the backreference to either html canvas or offscreen canvas should be named as
"canvas" consistently for all rendering contexts.

This CL changes the the different name "offscreencanvas" in
OffscreenCanvasRenderingContext2D. Also, this CL allows Webgl rendering contexts
that are created from OffscreenCanvas to return the OffscreenCanvas, and those
that are created from HTMLCanvas to return the HTMLCanvasElement, via the same
"canvas" attribute.

BUG=637022
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-08-11 23:39:49]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-08-11 23:43:21]

Description was changed from

==========
Updates on canvas backreference on canvas rendering contexts

Based on recent proposal (https://wiki.whatwg.org/wiki/OffscreenCanvas) change,
the backreference to either html canvas or offscreen canvas should be named as
"canvas" consistently for all rendering contexts.

This CL changes the the different name "offscreencanvas" in
OffscreenCanvasRenderingContext2D. Also, this CL allows Webgl rendering contexts
that are created from OffscreenCanvas to return the OffscreenCanvas, and those
that are created from HTMLCanvas to return the HTMLCanvasElement, via the same
"canvas" attribute.

BUG=637022
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Updates on canvas backreference on canvas rendering contexts

Based on recent proposal (https://wiki.whatwg.org/wiki/OffscreenCanvas) change,
the backreference to either html canvas or offscreen canvas should be named as
"canvas" consistently for all rendering contexts.

This CL changes the the different name "offscreencanvas" in
OffscreenCanvasRenderingContext2D. Also, this CL allows Webgl rendering contexts
that are created from OffscreenCanvas to return the OffscreenCanvas, and those
that are created from HTMLCanvas to return the HTMLCanvasElement, via the same
"canvas" attribute.

BUG=637022
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/903a3a827ddbf8dc46ada202c6768a997860c7bf
Cr-Commit-Position: refs/heads/master@{#411444}
==========

[commit-bot: I haz the power, 2016-08-11 23:43:22]

Patchset 11 (id:??) landed as
https://crrev.com/903a3a827ddbf8dc46ada202c6768a997860c7bf
Cr-Commit-Position: refs/heads/master@{#411444}