tests/PathOpsOpTest.cpp - Issue 2221153005: add flaky test option

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/PathOpsOpTest.cpp

Issue 2221153005: add flaky test option (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/PathOpsOpTest.cpp

diff --git a/tests/PathOpsOpTest.cpp b/tests/PathOpsOpTest.cpp

index a4aab37c6d39a9c2730703e462def29d485a1c1f..aba4e86ce5cc4ed3945f9352015f0773aec74982 100644

--- a/tests/PathOpsOpTest.cpp

+++ b/tests/PathOpsOpTest.cpp

@@ -6925,7 +6925,8 @@ path.conicTo(SkBits2Float(0x2a8c54ed), SkBits2Float(0x21081f21), SkBits2Float(0x

path.conicTo(SkBits2Float(0x68392d5b), SkBits2Float(0xf0682955), SkBits2Float(0x2a1f5b2d), SkBits2Float(0xef552a21), SkBits2Float(0x5b2d2a8c)); // 3.4979e+24f, -2.87402e+29f, 1.41537e-13f, -6.59712e+28f, 4.8742e+16f

SkPath path2(path);

- testPathOpSkipAssert(reporter, path1, path2, (SkPathOp) 0, filename);

+ // FIXME: fails on Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast, passes everywhere else

+ testPathOpFlakySkipAssert(reporter, path1, path2, (SkPathOp) 0, filename);

}

static void fuzz763_19(skiatest::Reporter* reporter, const char* filename) {

« no previous file with comments | « tests/PathOpsExtendedTest.cpp ('k') | no next file » | no next file with comments »