Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4770)

Unified Diff: chrome/browser/browsing_data/browsing_data_remover.h

Issue 2221143003: Formalize the restrictions of BrowsingDataRemover::RemoveWithFilter() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Explicit task count. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/browsing_data_remover.h
diff --git a/chrome/browser/browsing_data/browsing_data_remover.h b/chrome/browser/browsing_data/browsing_data_remover.h
index 5564dcc10be7619ecc07f2f75f736b306a239562..f379be7ed202209f2bb9ba3dcbc4b543e726cb1c 100644
--- a/chrome/browser/browsing_data/browsing_data_remover.h
+++ b/chrome/browser/browsing_data/browsing_data_remover.h
@@ -165,6 +165,12 @@ class BrowsingDataRemover : public KeyedService
#endif
REMOVE_SITE_USAGE_DATA,
+ // Datatypes that can be deleted partially per URL / origin / domain,
+ // whichever makes sense.
+ FILTERABLE_DATATYPES = (REMOVE_SITE_DATA & ~REMOVE_PLUGIN_DATA) |
+ REMOVE_CACHE |
+ REMOVE_DOWNLOADS,
+
// Includes all the available remove options. Meant to be used by clients
// that wish to wipe as much data as possible from a Profile, to make it
// look like a new Profile.
@@ -267,9 +273,7 @@ class BrowsingDataRemover : public KeyedService
// Like Remove(), but in case of URL-keyed only removes data whose URL match
// |filter_builder| (e.g. are on certain origin or domain).
- // TODO(dmurph): Support all backends with filter (crbug.com/113621).
- // DO NOT USE THIS METHOD UNLESS CALLER KNOWS WHAT THEY'RE DOING. NOT ALL
- // BACKENDS ARE SUPPORTED YET, AND MORE DATA THAN EXPECTED COULD BE DELETED.
+ // RemoveWithFilter() currently only works with FILTERABLE_DATATYPES.
void RemoveWithFilter(
const TimeRange& time_range,
int remove_mask,

Powered by Google App Engine
This is Rietveld 408576698