Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Side by Side Diff: chrome/browser/browsing_data/browsing_data_remover_unittest.cc

Issue 2221143003: Formalize the restrictions of BrowsingDataRemover::RemoveWithFilter() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/browsing_data/browsing_data_remover.h" 5 #include "chrome/browser/browsing_data/browsing_data_remover.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <list> 10 #include <list>
(...skipping 2676 matching lines...) Expand 10 before | Expand all | Expand 10 after
2687 nullptr); 2687 nullptr);
2688 tasks.emplace_back( 2688 tasks.emplace_back(
2689 BrowsingDataRemover::TimeRange(base::Time::Now(), base::Time::Max()), 2689 BrowsingDataRemover::TimeRange(base::Time::Now(), base::Time::Max()),
2690 BrowsingDataRemover::REMOVE_PASSWORDS, 2690 BrowsingDataRemover::REMOVE_PASSWORDS,
2691 BrowsingDataHelper::ALL, 2691 BrowsingDataHelper::ALL,
2692 base::WrapUnique(new RegistrableDomainFilterBuilder( 2692 base::WrapUnique(new RegistrableDomainFilterBuilder(
2693 RegistrableDomainFilterBuilder::BLACKLIST)), 2693 RegistrableDomainFilterBuilder::BLACKLIST)),
2694 observer.target_b()); 2694 observer.target_b());
2695 tasks.emplace_back( 2695 tasks.emplace_back(
2696 BrowsingDataRemover::TimeRange(base::Time(), base::Time::UnixEpoch()), 2696 BrowsingDataRemover::TimeRange(base::Time(), base::Time::UnixEpoch()),
2697 BrowsingDataRemover::REMOVE_PASSWORDS, 2697 BrowsingDataRemover::REMOVE_WEBSQL,
2698 BrowsingDataHelper::UNPROTECTED_WEB, 2698 BrowsingDataHelper::UNPROTECTED_WEB,
2699 std::move(filter_builder_1), 2699 std::move(filter_builder_1),
2700 observer.target_b()); 2700 observer.target_b());
2701 tasks.emplace_back( 2701 tasks.emplace_back(
2702 BrowsingDataRemover::TimeRange( 2702 BrowsingDataRemover::TimeRange(
2703 base::Time::UnixEpoch(), base::Time::Now()), 2703 base::Time::UnixEpoch(), base::Time::Now()),
2704 BrowsingDataRemover::REMOVE_CHANNEL_IDS, 2704 BrowsingDataRemover::REMOVE_CHANNEL_IDS,
2705 BrowsingDataHelper::ALL, 2705 BrowsingDataHelper::ALL,
2706 std::move(filter_builder_2), 2706 std::move(filter_builder_2),
2707 nullptr); 2707 nullptr);
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
2787 EXPECT_TRUE(remover->is_removing()); 2787 EXPECT_TRUE(remover->is_removing());
2788 2788
2789 // Add one more deletion and wait for it. 2789 // Add one more deletion and wait for it.
2790 BlockUntilBrowsingDataRemoved( 2790 BlockUntilBrowsingDataRemoved(
2791 browsing_data::ALL_TIME, 2791 browsing_data::ALL_TIME,
2792 BrowsingDataRemover::REMOVE_COOKIES, 2792 BrowsingDataRemover::REMOVE_COOKIES,
2793 BrowsingDataHelper::UNPROTECTED_WEB); 2793 BrowsingDataHelper::UNPROTECTED_WEB);
2794 2794
2795 EXPECT_FALSE(remover->is_removing()); 2795 EXPECT_FALSE(remover->is_removing());
2796 } 2796 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698