Formalize the restrictions of BrowsingDataRemover::RemoveWithFilter()

chrome/browser/browsing_data/browsing_data_remover.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_
 #define CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_
 
 #include <stdint.h>
 
 #include <queue>
@@ skipping 147 matching lines @@
                        REMOVE_PLUGIN_DATA |
                        REMOVE_SERVICE_WORKERS |
                        REMOVE_CACHE_STORAGE |
                        REMOVE_WEBSQL |
                        REMOVE_CHANNEL_IDS |
 #if BUILDFLAG(ANDROID_JAVA_UI)
                        REMOVE_WEBAPP_DATA |
 #endif
                        REMOVE_SITE_USAGE_DATA,
 
+    // Datatypes that can be deleted partially per URL / origin / domain,
+    // whichever makes sense.
+    FILTERABLE_DATATYPES = (REMOVE_SITE_DATA & ~REMOVE_PLUGIN_DATA) |
+                           REMOVE_CACHE |

[Bernhard Bauer, 2016/08/10 14:22:14]

Indent one more space.

[msramek, 2016/08/11 13:11:01]

Done.

+                           REMOVE_DOWNLOADS,
+
     // Includes all the available remove options. Meant to be used by clients
     // that wish to wipe as much data as possible from a Profile, to make it
     // look like a new Profile.
     REMOVE_ALL = REMOVE_SITE_DATA | REMOVE_CACHE | REMOVE_DOWNLOADS |
                  REMOVE_FORM_DATA |
                  REMOVE_HISTORY |
                  REMOVE_PASSWORDS |
                  REMOVE_MEDIA_LICENSES,
 
     // Includes all available remove options. Meant to be used when the Profile
@@ skipping 82 matching lines @@
 
   // A version of the above that in addition informs the |observer| when the
   // removal task is finished.
   void RemoveAndReply(const TimeRange& time_range,
                       int remove_mask,
                       int origin_type_mask,
                       Observer* observer);
 
   // Like Remove(), but in case of URL-keyed only removes data whose URL match
   // |filter_builder| (e.g. are on certain origin or domain).
-  // TODO(dmurph): Support all backends with filter (crbug.com/113621).
-  // DO NOT USE THIS METHOD UNLESS CALLER KNOWS WHAT THEY'RE DOING. NOT ALL
-  // BACKENDS ARE SUPPORTED YET, AND MORE DATA THAN EXPECTED COULD BE DELETED.
+  // RemoveWithFilter() currently only works with FILTERABLE_DATATYPES.
   void RemoveWithFilter(
       const TimeRange& time_range,
       int remove_mask,
       int origin_type_mask,
       std::unique_ptr<BrowsingDataFilterBuilder> filter_builder);
 
   // A version of the above that in addition informs the |observer| when the
   // removal task is finished.
   void RemoveWithFilterAndReply(
       const TimeRange& time_range,
@@ skipping 299 matching lines @@
   // not initialised, so the registry must be mocked out.
   std::unique_ptr<WebappRegistry> webapp_registry_;
 #endif
 
   base::WeakPtrFactory<BrowsingDataRemover> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowsingDataRemover);
 };
 
 #endif  // CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_