Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Side by Side Diff: chrome/browser/browsing_data/browsing_data_remover_unittest.cc

Issue 2221143003: Formalize the restrictions of BrowsingDataRemover::RemoveWithFilter() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Explicit task count. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/browsing_data/browsing_data_remover.h" 5 #include "chrome/browser/browsing_data/browsing_data_remover.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <list> 10 #include <list>
(...skipping 2814 matching lines...) Expand 10 before | Expand all | Expand 10 after
2825 nullptr); 2825 nullptr);
2826 tasks.emplace_back( 2826 tasks.emplace_back(
2827 BrowsingDataRemover::TimeRange(base::Time::Now(), base::Time::Max()), 2827 BrowsingDataRemover::TimeRange(base::Time::Now(), base::Time::Max()),
2828 BrowsingDataRemover::REMOVE_PASSWORDS, 2828 BrowsingDataRemover::REMOVE_PASSWORDS,
2829 BrowsingDataHelper::ALL, 2829 BrowsingDataHelper::ALL,
2830 base::WrapUnique(new RegistrableDomainFilterBuilder( 2830 base::WrapUnique(new RegistrableDomainFilterBuilder(
2831 RegistrableDomainFilterBuilder::BLACKLIST)), 2831 RegistrableDomainFilterBuilder::BLACKLIST)),
2832 observer.target_b()); 2832 observer.target_b());
2833 tasks.emplace_back( 2833 tasks.emplace_back(
2834 BrowsingDataRemover::TimeRange(base::Time(), base::Time::UnixEpoch()), 2834 BrowsingDataRemover::TimeRange(base::Time(), base::Time::UnixEpoch()),
2835 BrowsingDataRemover::REMOVE_PASSWORDS, 2835 BrowsingDataRemover::REMOVE_WEBSQL,
2836 BrowsingDataHelper::UNPROTECTED_WEB, 2836 BrowsingDataHelper::UNPROTECTED_WEB,
2837 std::move(filter_builder_1), 2837 std::move(filter_builder_1),
2838 observer.target_b()); 2838 observer.target_b());
2839 tasks.emplace_back( 2839 tasks.emplace_back(
2840 BrowsingDataRemover::TimeRange( 2840 BrowsingDataRemover::TimeRange(
2841 base::Time::UnixEpoch(), base::Time::Now()), 2841 base::Time::UnixEpoch(), base::Time::Now()),
2842 BrowsingDataRemover::REMOVE_CHANNEL_IDS, 2842 BrowsingDataRemover::REMOVE_CHANNEL_IDS,
2843 BrowsingDataHelper::ALL, 2843 BrowsingDataHelper::ALL,
2844 std::move(filter_builder_2), 2844 std::move(filter_builder_2),
2845 nullptr); 2845 nullptr);
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
2925 EXPECT_TRUE(remover->is_removing()); 2925 EXPECT_TRUE(remover->is_removing());
2926 2926
2927 // Add one more deletion and wait for it. 2927 // Add one more deletion and wait for it.
2928 BlockUntilBrowsingDataRemoved( 2928 BlockUntilBrowsingDataRemoved(
2929 browsing_data::ALL_TIME, 2929 browsing_data::ALL_TIME,
2930 BrowsingDataRemover::REMOVE_COOKIES, 2930 BrowsingDataRemover::REMOVE_COOKIES,
2931 BrowsingDataHelper::UNPROTECTED_WEB); 2931 BrowsingDataHelper::UNPROTECTED_WEB);
2932 2932
2933 EXPECT_FALSE(remover->is_removing()); 2933 EXPECT_FALSE(remover->is_removing());
2934 } 2934 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698