Issue 2221133002: Refactor various gradient effect classes

Issue 2221133002: Refactor various gradient effect classes (Closed)

Created:
4 years, 4 months ago by fmenozzi

Modified:
4 years, 4 months ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Total comments: 2

Created: 4 years, 4 months ago

	Unified diffs	Side-by-side diffs	Stats (+201 lines, -159 lines)
M	src/effects/gradients/SkGradientShader.cpp	View	4 chunks	+14 lines, -14 lines	0 comments
M	src/effects/gradients/SkGradientShaderPriv.h	View	3 chunks	+4 lines, -4 lines	0 comments
M	src/effects/gradients/SkLinearGradient.cpp	View	5 chunks	+35 lines, -28 lines	0 comments
M	src/effects/gradients/SkRadialGradient.cpp	View	4 chunks	+34 lines, -27 lines	0 comments
M	src/effects/gradients/SkSweepGradient.cpp	View	4 chunks	+35 lines, -27 lines	0 comments
M	src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp	View	34 chunks	+79 lines, -59 lines	0 comments

Total messages: 11 (4 generated)

fmenozzi

Did this a while ago but I was dumb and didn't make it its own ...

4 years, 4 months ago (2016-08-08 19:28:10 UTC) #3

bsalomon

looks good modulo some style nits. Lines should wrap at 100 cols and two things ...

4 years, 4 months ago (2016-08-09 13:47:05 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2221133002/20001

4 years, 4 months ago (2016-08-09 14:36:19 UTC) #9

commit-bot: I haz the power

4 years, 4 months ago (2016-08-09 15:06:03 UTC) #11

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/55d318d35f672e9a4b7e1f2f10ce4e31312f49b6