Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1054)

Issue 2221113003: Revert of Refactor download image-MIME-type-detection code. (Closed)

Created:
4 years, 4 months ago by Daniel Erat
Modified:
4 years, 4 months ago
CC:
chromium-reviews, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Refactor download image-MIME-type-detection code. (patchset #3 id:40001 of https://codereview.chromium.org/2219953004/ ) Reason for revert: accidentally mixed in another change (https://codereview.chromium.org/2225543002/) Original issue's description: > Refactor download image-MIME-type-detection code. > > Refactor duplicated image-MIME-type-detection code from > DownloadCommands and DownloadItemNotification into a new > DownloadItemModel::HasSupportedImageMimeType() method. > > BUG=605805 > > Committed: https://crrev.com/759969dbc064ab0925287ad8a62eacf588faec7f > Cr-Commit-Position: refs/heads/master@{#410382} TBR=rdsmith@chromium.org,svaldez@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=605805 Committed: https://crrev.com/f05766e8629713e1ad10dc81cdd56558b6ea0427 Cr-Commit-Position: refs/heads/master@{#410403}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -175 lines) Patch
M ash/common/system/chromeos/palette/palette_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/note_taking_app_utils.h View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/chromeos/note_taking_app_utils.cc View 1 chunk +0 lines, -83 lines 0 comments Download
M chrome/browser/download/download_commands.cc View 2 chunks +18 lines, -5 lines 0 comments Download
M chrome/browser/download/download_item_model.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/download/download_item_model.cc View 2 chunks +0 lines, -19 lines 0 comments Download
M chrome/browser/download/download_item_model_unittest.cc View 2 chunks +0 lines, -28 lines 0 comments Download
M chrome/browser/download/notification/download_item_notification.cc View 1 chunk +16 lines, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Daniel Erat
Created Revert of Refactor download image-MIME-type-detection code.
4 years, 4 months ago (2016-08-08 18:49:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2221113003/1
4 years, 4 months ago (2016-08-08 18:50:03 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 18:50:54 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 18:52:53 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f05766e8629713e1ad10dc81cdd56558b6ea0427
Cr-Commit-Position: refs/heads/master@{#410403}

Powered by Google App Engine
This is Rietveld 408576698