Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1154)

Unified Diff: content/browser/devtools/protocol/network_handler.h

Issue 2221093003: [Devtools] Backend support for setCookie (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: done Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/network_handler.h
diff --git a/content/browser/devtools/protocol/network_handler.h b/content/browser/devtools/protocol/network_handler.h
index d3270628aafcfa64c5674605dba5a8243c737357..a96c6feb1e22f42a6830b3ec4098514325489914 100644
--- a/content/browser/devtools/protocol/network_handler.h
+++ b/content/browser/devtools/protocol/network_handler.h
@@ -20,7 +20,7 @@ namespace network {
class NetworkHandler {
public:
typedef DevToolsProtocolClient::Response Response;
-
+ typedef base::Callback<void(bool)> SetCookieResultCallback;
dgozman 2016/08/12 05:22:46 Modern style says typedef -> using.
allada 2016/08/16 01:10:40 Done.
NetworkHandler();
virtual ~NetworkHandler();
@@ -34,6 +34,17 @@ class NetworkHandler {
const std::string& cookie_name,
const std::string& url);
+ Response SetCookie(DevToolsCommandId command_id,
+ const std::string& url,
+ const std::string& name,
+ const std::string& value,
+ const std::string* domain,
+ const std::string* path,
+ bool* secure,
+ bool* httpOnly,
dgozman 2016/08/12 05:22:46 snake_case everywhere please
allada 2016/08/16 01:10:39 Done.
+ const std::string* sameSite,
+ double* expires);
+
Response CanEmulateNetworkConditions(bool* result);
Response EmulateNetworkConditions(bool offline,
double latency,
@@ -49,6 +60,7 @@ class NetworkHandler {
DevToolsCommandId command_id,
const net::CookieList& cookie_list);
void SendDeleteCookieResponse(DevToolsCommandId command_id);
+ void SendSetCookieResponse(DevToolsCommandId command_id, bool success);
RenderFrameHostImpl* host_;
std::unique_ptr<Client> client_;

Powered by Google App Engine
This is Rietveld 408576698