ui/webui/resources/cr_elements/shared_vars_css.html - Issue 2221073004: Replace deprecated iron-flex-layout/classes with iron-flex-layout-class in MD Settings

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/webui/resources/cr_elements/shared_vars_css.html

Issue 2221073004: Replace deprecated iron-flex-layout/classes with iron-flex-layout-class in MD Settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color.html ">	1 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color.html ">

2	2

3 <!-- Common css variables for Material Design WebUI. -->	3 <!-- Common css variables for Material Design WebUI. -->

4 <style is="custom-style">	4 <style is="custom-style">

5 :root {	5 :root {

6 --cr-actionable: {	6 --cr-actionable: {

7 cursor: pointer;	7 cursor: pointer;

8 };	8 };

9 --cr-focused-item-color: var(--google-grey-300);	9 --cr-focused-item-color: var(--google-grey-300);

10 --cr-separator-line: 1px solid rgba(0, 0, 0, 0.06);	10 --cr-separator-line: 1px solid rgba(0, 0, 0, 0.06);

11 }	11 }

	12

	13 /*

	14 * Because everyone assumes [hidden] overrides {display: foo}.

	15 * TODO(michaelpg): Rename to shared_global_css.html and import only from

	16 * entry points (md_foo.html and tests). Eventually find alternative solution

	17 * to this deprecated /deep/ selector (crbug.com/498405).

	18 */

	19 :root /deep/ [hidden] {

	20 display: none !important;

	21 }
	dschuyler 2016/08/09 02:24:11 Could this be a separate CL? Could this be a separate CL? michaelpg 2016/08/09 02:49:00 It would have to be a precursor CL, as this rule i Show quoted text On 2016/08/09 02:24:11, dschuyler wrote: > Could this be a separate CL? It would have to be a precursor CL, as this rule is necessary for hidden to work as we expect. SGTY? dschuyler 2016/08/09 17:19:13 Yeah. I'd like git bisect to be able to help test Show quoted text On 2016/08/09 02:49:00, michaelpg wrote: > On 2016/08/09 02:24:11, dschuyler wrote: > > Could this be a separate CL? > > It would have to be a precursor CL, as this rule is necessary for hidden to work > as we expect. SGTY? Yeah. I'd like git bisect to be able to help test these changes separately (if that comes up in the future). michaelpg 2016/08/10 16:11:17 Done. Show quoted text On 2016/08/09 17:19:13, dschuyler wrote: > On 2016/08/09 02:49:00, michaelpg wrote: > > On 2016/08/09 02:24:11, dschuyler wrote: > > > Could this be a separate CL? > > > > It would have to be a precursor CL, as this rule is necessary for hidden to > work > > as we expect. SGTY? > > Yeah. I'd like git bisect to be able to help test these > changes separately (if that comes up in the future). Done.
12 </style>	22 </style>

OLD	NEW

« chrome/browser/resources/settings/internet_page/internet_page.html ('K') | « chrome/browser/resources/settings/site_settings/site_list.html ('k') | no next file » | no next file with comments »