Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2815)

Unified Diff: base/debug/stack_trace_posix.cc

Issue 2221063004: Make the SandboxSymbolizeHelper Singleton Leaky and Enable Impacted Test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add In Task Tracker Unit Test Enable Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/task_scheduler/task_tracker_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/debug/stack_trace_posix.cc
diff --git a/base/debug/stack_trace_posix.cc b/base/debug/stack_trace_posix.cc
index fc3ee14c7b9d60958ad6d6000d94cbc616b6c7df..27a656e6caffe7a3efc58fda7c4758b5d7fcdf77 100644
--- a/base/debug/stack_trace_posix.cc
+++ b/base/debug/stack_trace_posix.cc
@@ -444,8 +444,6 @@ void WarmUpBacktrace() {
StackTrace stack_trace;
}
-} // namespace
-
#if defined(USE_SYMBOLIZE)
// class SandboxSymbolizeHelper.
@@ -461,7 +459,8 @@ class SandboxSymbolizeHelper {
public:
// Returns the singleton instance.
static SandboxSymbolizeHelper* GetInstance() {
- return Singleton<SandboxSymbolizeHelper>::get();
+ return Singleton<SandboxSymbolizeHelper,
+ LeakySingletonTraits<SandboxSymbolizeHelper>>::get();
}
private:
@@ -677,6 +676,8 @@ class SandboxSymbolizeHelper {
};
#endif // USE_SYMBOLIZE
+} // namespace
+
bool EnableInProcessStackDumping() {
#if defined(USE_SYMBOLIZE)
SandboxSymbolizeHelper::GetInstance();
« no previous file with comments | « no previous file | base/task_scheduler/task_tracker_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698