Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2221063002: Handle missing super call lint warnings. (Closed)

Created:
4 years, 4 months ago by estevenson
Modified:
4 years, 4 months ago
Reviewers:
Theresa, Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle missing super call lint warnings. This CL addresses 3 MissingSuperCall lint warnings. BUG=635567 Committed: https://crrev.com/d2bf24f0b82526d6b93be397840557be4826255c Cr-Commit-Position: refs/heads/master@{#410466}

Patch Set 1 #

Patch Set 2 : Add inline comments explaining suppressions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
estevenson
ptal
4 years, 4 months ago (2016-08-08 18:34:54 UTC) #6
Theresa
The super call for onMultiWindowModeChanged lgtm (thanks for adding it now that the support library ...
4 years, 4 months ago (2016-08-08 18:41:19 UTC) #8
estevenson
4 years, 4 months ago (2016-08-08 19:01:51 UTC) #10
Yaron
lgtm As an FYI for the future (or larger CLs), when you have multiple reviewers, ...
4 years, 4 months ago (2016-08-08 20:29:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2221063002/20001
4 years, 4 months ago (2016-08-08 20:31:29 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-08 21:28:00 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 21:30:23 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d2bf24f0b82526d6b93be397840557be4826255c
Cr-Commit-Position: refs/heads/master@{#410466}

Powered by Google App Engine
This is Rietveld 408576698