Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: xfa/fxbarcode/BC_TwoDimWriter.h

Issue 2221023003: Use smart pointers for class owned pointers in xfa/fxbarcode (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: xfa/fxbarcode/BC_TwoDimWriter.h
diff --git a/xfa/fxbarcode/BC_TwoDimWriter.h b/xfa/fxbarcode/BC_TwoDimWriter.h
index da2e6d9c4d4eca2cf95c475daad5d73d289e06de..d35f5883d90e52a4c1e1cc64db4a0c969d29beb0 100644
--- a/xfa/fxbarcode/BC_TwoDimWriter.h
+++ b/xfa/fxbarcode/BC_TwoDimWriter.h
@@ -7,6 +7,8 @@
#ifndef XFA_FXBARCODE_BC_TWODIMWRITER_H_
#define XFA_FXBARCODE_BC_TWODIMWRITER_H_
+#include <memory>
+
#include "xfa/fxbarcode/BC_Writer.h"
class CBC_CommonBitMatrix;
@@ -25,12 +27,12 @@ class CBC_TwoDimWriter : public CBC_Writer {
virtual void RenderDeviceResult(CFX_RenderDevice* device,
const CFX_Matrix* matrix);
virtual FX_BOOL SetErrorCorrectionLevel(int32_t level) = 0;
- virtual int32_t GetErrorCorrectionLevel();
+ virtual int32_t GetErrorCorrectionLevel() const;
Lei Zhang 2016/08/09 00:23:43 BTW, I don't think anyone is overriding this.
Wei Li 2016/08/09 19:31:22 Done.
protected:
int32_t m_iCorrectLevel;
FX_BOOL m_bFixedSize;
- CBC_CommonBitMatrix* m_output;
+ std::unique_ptr<CBC_CommonBitMatrix> m_output;
};
#endif // XFA_FXBARCODE_BC_TWODIMWRITER_H_
« no previous file with comments | « no previous file | xfa/fxbarcode/BC_TwoDimWriter.cpp » ('j') | xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698