Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2221003002: Don't preallocate temps, params, decls space if we're ScopeInfo backed (Closed)

Created:
4 years, 4 months ago by Toon Verwaest
Modified:
4 years, 4 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't preallocate temps, params, decls space if we're ScopeInfo backed Such scopes don't use those lists. BUG=v8:5209 Committed: https://crrev.com/a9d00623e6aeb86da5dada13d775fa744efd3ae2 Cr-Commit-Position: refs/heads/master@{#38485}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M src/ast/scopes.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/ast/scopes.cc View 1 5 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 4 months ago (2016-08-08 12:08:14 UTC) #2
marja
lgtm
4 years, 4 months ago (2016-08-09 11:01:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2221003002/20001
4 years, 4 months ago (2016-08-09 11:21:28 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-09 11:44:50 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 11:45:09 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a9d00623e6aeb86da5dada13d775fa744efd3ae2
Cr-Commit-Position: refs/heads/master@{#38485}

Powered by Google App Engine
This is Rietveld 408576698