Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 22210002: arm: Look for __SOFTFP__ besides __SOFTP. (Closed)

Created:
7 years, 4 months ago by Raphael Kubo da Costa (rakuco)
Modified:
7 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

r11951 changed the existing check for the __SOFTFP__ define in ARM platforms to a check for __SOFTP. Most other programs look for __SOFTFP__ [1], so look for both to increase the chances of not erroring out when using GCC 4.5. [1] Based on http://codesearch.debian.net/search?q=__SOFTFP__ vs http://codesearch.debian.net/search?q=__SOFTFP[^_] BUG=v8:2140 R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16070

Patch Set 1 #

Patch Set 2 : Look for both defines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/platform-linux.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Raphael Kubo da Costa (rakuco)
7 years, 4 months ago (2013-08-05 15:06:07 UTC) #1
Benedikt Meurer
Hm, why not test for __SOFTFP__ or __SOFTFP? I don't like to break builds that ...
7 years, 4 months ago (2013-08-06 06:56:01 UTC) #2
Raphael Kubo da Costa (rakuco)
On 2013/08/06 06:56:01, Benedikt Meurer wrote: > Hm, why not test for __SOFTFP__ or __SOFTFP? ...
7 years, 4 months ago (2013-08-06 08:32:47 UTC) #3
Raphael Kubo da Costa (rakuco)
I've also updated the commit message in the CL.
7 years, 4 months ago (2013-08-06 10:33:17 UTC) #4
Benedikt Meurer
LGTM
7 years, 4 months ago (2013-08-06 10:33:53 UTC) #5
Benedikt Meurer
7 years, 4 months ago (2013-08-06 11:08:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r16070 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698