Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2220993003: [api] Templatize do_callback parameter in CallDepthScope (Closed)

Created:
4 years, 4 months ago by Camillo Bruni
Modified:
4 years, 4 months ago
Reviewers:
Franzi
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Templatize do_callback parameter in CallDepthScope Drive-by-fix: mark isolates as const in stack-allocated scopes BUG=chromium:630217 Committed: https://crrev.com/0cabbd3d60acf1e040113d59e4cdbc99b953843b Cr-Commit-Position: refs/heads/master@{#38496}

Patch Set 1 #

Patch Set 2 : adding one more const #

Patch Set 3 : formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -21 lines) Patch
M include/v8.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/api.cc View 1 2 4 chunks +10 lines, -17 lines 0 comments Download
M src/isolate.h View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
Camillo Bruni
PTAL
4 years, 4 months ago (2016-08-08 12:43:51 UTC) #3
Franzi
lgtm
4 years, 4 months ago (2016-08-09 11:58:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220993003/20001
4 years, 4 months ago (2016-08-09 12:01:54 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/22426) v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
4 years, 4 months ago (2016-08-09 12:04:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220993003/40001
4 years, 4 months ago (2016-08-09 13:31:18 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-09 13:57:38 UTC) #17
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/0cabbd3d60acf1e040113d59e4cdbc99b953843b Cr-Commit-Position: refs/heads/master@{#38496}
4 years, 4 months ago (2016-08-09 13:57:57 UTC) #19
Camillo Bruni
4 years, 4 months ago (2016-08-16 13:38:49 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2248063002/ by cbruni@chromium.org.

The reason for reverting is: breaks checks.

Powered by Google App Engine
This is Rietveld 408576698