Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2220983002: Fix return type for JoinMulticast. (Closed)

Created:
4 years, 4 months ago by floitsch
Modified:
4 years, 4 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M runtime/bin/socket_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/raw_datagram_socket_test.dart View 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
floitsch
4 years, 4 months ago (2016-08-08 09:36:06 UTC) #2
Søren Gjesse
lgtm
4 years, 4 months ago (2016-08-08 10:04:19 UTC) #3
floitsch
4 years, 4 months ago (2016-08-08 10:22:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
596723f0c32b98b953ef5e5068911d334ba308a4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698