Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2220933004: Revert of Cleanup use of legacy SkSurface creation methods a bit (Closed)

Created:
4 years, 4 months ago by robertphillips
Modified:
4 years, 4 months ago
Reviewers:
dogben, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Cleanup use of legacy SkSurface creation methods a bit (patchset #2 id:20001 of https://codereview.chromium.org/2223023002/ ) Reason for revert: webkit_headless! Original issue's description: > Cleanup use of legacy SkSurface creation methods a bit > > This: > removes the SK_SUPPORT_LEGACY_NEW_SURFACE_API flag from the bzl build > cleans up some remaining uses of the old API > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2223023002 > > Committed: https://skia.googlesource.com/skia/+/f21cd16228c20927fa4e9b937d6951471cfaa37a TBR=benjaminwagner@google.com,egdaniel@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/0652baa23ec2ea9e1bcdf686bf1e1118b186b42c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -11 lines) Patch
M experimental/GLFWTest/glfw_main.cpp View 1 chunk +1 line, -1 line 0 comments Download
M platform_tools/android/apps/canvasproof/src/main/jni/org_skia_canvasproof_GaneshPictureRenderer.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M platform_tools/android/examples/hello_skia_app/jni/helloskia.cpp View 2 chunks +1 line, -8 lines 0 comments Download
M public.bzl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
robertphillips
Created Revert of Cleanup use of legacy SkSurface creation methods a bit
4 years, 4 months ago (2016-08-08 16:17:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220933004/1
4 years, 4 months ago (2016-08-08 16:17:16 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 16:17:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0652baa23ec2ea9e1bcdf686bf1e1118b186b42c

Powered by Google App Engine
This is Rietveld 408576698