Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2220933003: [SVGDom] Improved transform parsing (Closed)

Created:
4 years, 4 months ago by f(malita)
Modified:
4 years, 4 months ago
CC:
reviews_skia.org, reed1
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

[SVGDom] Improved transform parsing Update 'transform' attribute parsing to a more robust, SkSVGAttributeParser-based implementation. R=robertphillips@google.com,stephana@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2220933003 Committed: https://skia.googlesource.com/skia/+/c97796b47b2f3e0ca8c04073c1576db21b58eedb

Patch Set 1 #

Patch Set 2 : simplified #

Patch Set 3 : rebase #

Total comments: 6

Patch Set 4 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -62 lines) Patch
M experimental/svg/model/SkSVGAttributeParser.h View 1 2 3 2 chunks +14 lines, -0 lines 0 comments Download
M experimental/svg/model/SkSVGAttributeParser.cpp View 1 2 1 chunk +141 lines, -0 lines 0 comments Download
M experimental/svg/model/SkSVGDOM.cpp View 1 3 chunks +7 lines, -49 lines 0 comments Download
M experimental/svg/model/SkSVGTransformableNode.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M experimental/svg/model/SkSVGTransformableNode.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M experimental/svg/model/SkSVGTypes.h View 1 2 chunks +5 lines, -3 lines 0 comments Download
M experimental/svg/model/SkSVGValue.h View 1 2 1 chunk +5 lines, -5 lines 0 comments Download

Depends on Patchset:

Issue 2222793002 Patch 80001

Messages

Total messages: 11 (5 generated)
f(malita)
Depends on https://codereview.chromium.org/2222793002/.
4 years, 4 months ago (2016-08-08 17:20:42 UTC) #4
robertphillips
https://codereview.chromium.org/2220933003/diff/40001/experimental/svg/model/SkSVGAttributeParser.cpp File experimental/svg/model/SkSVGAttributeParser.cpp (right): https://codereview.chromium.org/2220933003/diff/40001/experimental/svg/model/SkSVGAttributeParser.cpp#newcode239 experimental/svg/model/SkSVGAttributeParser.cpp:239: if (!(this->parseScalarToken(scalars + i) && Why "i > 4" ...
4 years, 4 months ago (2016-08-08 17:48:47 UTC) #5
f(malita)
https://codereview.chromium.org/2220933003/diff/40001/experimental/svg/model/SkSVGAttributeParser.cpp File experimental/svg/model/SkSVGAttributeParser.cpp (right): https://codereview.chromium.org/2220933003/diff/40001/experimental/svg/model/SkSVGAttributeParser.cpp#newcode239 experimental/svg/model/SkSVGAttributeParser.cpp:239: if (!(this->parseScalarToken(scalars + i) && On 2016/08/08 17:48:47, robertphillips ...
4 years, 4 months ago (2016-08-08 17:53:16 UTC) #6
robertphillips
lgtm
4 years, 4 months ago (2016-08-08 17:59:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220933003/60001
4 years, 4 months ago (2016-08-08 19:40:27 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 19:59:00 UTC) #11
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/c97796b47b2f3e0ca8c04073c1576db21b58eedb

Powered by Google App Engine
This is Rietveld 408576698