Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2220933002:
Empty program info log should not be a '\0' string in WebGL (Closed)
DescriptionEmpty program info log should not be a '\0' string in WebGL
BUG=635417
TEST=conformance/programs/program-infolog.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/c54b546d3d2155e9973f7bf8d450c2374026acef
Cr-Commit-Position: refs/heads/master@{#410527}
Patch Set 1 #
Total comments: 2
Patch Set 2 : replace length with empty #Messages
Total messages: 18 (10 generated)
Description was changed from ========== Empty program info log shouldnot be a '\0' string in WebGL BUG= TEST=conformance/programs/program-infolog.html ========== to ========== Empty program info log shouldnot be a '\0' string in WebGL BUG= TEST=conformance/programs/program-infolog.html CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Empty program info log shouldnot be a '\0' string in WebGL BUG= TEST=conformance/programs/program-infolog.html CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Empty program info log should not be a '\0' string in WebGL BUG=635417 TEST=conformance/programs/program-infolog.html CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
qiankun.miao@intel.com changed reviewers: + kbr@chromium.org, yunchao.he@intel.com, zmo@chromium.org
PTAL.
Thanks for fixing this. https://codereview.chromium.org/2220933002/diff/1/gpu/command_buffer/service/... File gpu/command_buffer/service/program_manager.cc (right): https://codereview.chromium.org/2220933002/diff/1/gpu/command_buffer/service/... gpu/command_buffer/service/program_manager.cc:495: set_log_info(log.length() ? log.c_str() : nullptr); log.empty() is better
https://codereview.chromium.org/2220933002/diff/1/gpu/command_buffer/service/... File gpu/command_buffer/service/program_manager.cc (right): https://codereview.chromium.org/2220933002/diff/1/gpu/command_buffer/service/... gpu/command_buffer/service/program_manager.cc:495: set_log_info(log.length() ? log.c_str() : nullptr); On 2016/08/08 16:36:15, Zhenyao Mo wrote: > log.empty() is better Done.
On 2016/08/08 23:31:02, qiankun wrote: > https://codereview.chromium.org/2220933002/diff/1/gpu/command_buffer/service/... > File gpu/command_buffer/service/program_manager.cc (right): > > https://codereview.chromium.org/2220933002/diff/1/gpu/command_buffer/service/... > gpu/command_buffer/service/program_manager.cc:495: set_log_info(log.length() ? > log.c_str() : nullptr); > On 2016/08/08 16:36:15, Zhenyao Mo wrote: > > log.empty() is better > > Done. lgtm
The CQ bit was checked by qiankun.miao@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
non-owner LGTM too.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by qiankun.miao@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Empty program info log should not be a '\0' string in WebGL BUG=635417 TEST=conformance/programs/program-infolog.html CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Empty program info log should not be a '\0' string in WebGL BUG=635417 TEST=conformance/programs/program-infolog.html CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Empty program info log should not be a '\0' string in WebGL BUG=635417 TEST=conformance/programs/program-infolog.html CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Empty program info log should not be a '\0' string in WebGL BUG=635417 TEST=conformance/programs/program-infolog.html CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/c54b546d3d2155e9973f7bf8d450c2374026acef Cr-Commit-Position: refs/heads/master@{#410527} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c54b546d3d2155e9973f7bf8d450c2374026acef Cr-Commit-Position: refs/heads/master@{#410527} |
