Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2220923002: Make computeInlineBoxPosition() to handle unicode-bidi:isolate correctly (Closed)

Created:
4 years, 4 months ago by yosin_UTC9
Modified:
4 years, 4 months ago
Reviewers:
kojii
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make computeInlineBoxPosition() to handle unicode-bidi:isolate correctly This patch makes |computeInlineBoxPosition()| to handle "unicode-bidi:isolate" correctly for position at start of text by checking text direction and bidi embedding level rather than only checking bidi embedding level. BUG=600334 TEST=run-webkit-unit-tests --gtest_filter=VisibleUnitsTest.computeInlineBoxPositionBidiIsolate Committed: https://crrev.com/ec6d070e13bb453972f0c385e090df9e2e5f9478 Cr-Commit-Position: refs/heads/master@{#410325}

Patch Set 1 : 2016-08-08T15:03:39 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -4 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 2 chunks +16 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp View 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
yosin_UTC9
PTAL
4 years, 4 months ago (2016-08-08 09:27:47 UTC) #9
kojii
lgtm
4 years, 4 months ago (2016-08-08 10:07:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220923002/1
4 years, 4 months ago (2016-08-08 10:31:50 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 10:34:56 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 10:37:04 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec6d070e13bb453972f0c385e090df9e2e5f9478
Cr-Commit-Position: refs/heads/master@{#410325}

Powered by Google App Engine
This is Rietveld 408576698