Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2220863002: Cached style element sheets may not have an owner node. (Closed)

Created:
4 years, 4 months ago by rune
Modified:
4 years, 4 months ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cached style element sheets may not have an owner node. The assert for cacheability of shared StyleSheetContents required the ownerNode to be a non-null style element. Referring to and modify a stylesheet is however possible after the style element has been removed and the ownerNode set to null. Change the assert to just check for the two types of cacheability. This was not triggered by stylesheets not having @media rules since the cacheability of linked resources would be true and made the assert true. Also, made the ASSERT a DCHECK along with the other ASSERTs in the modified file. R=meade@chromium.org BUG=635022 Committed: https://crrev.com/d70bbabbe7641c768c9c2667658b6e85a4accb09 Cr-Commit-Position: refs/heads/master@{#410305}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -20 lines) Patch
A third_party/WebKit/LayoutTests/fast/css/modify-cached-detached-sheet-3.html View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSStyleSheet.cpp View 10 chunks +12 lines, -20 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
rune
ptal
4 years, 4 months ago (2016-08-07 23:38:02 UTC) #3
meade_UTC10
lgtm Style team is having a clusterfuzz/crash bug fixit today, thanks for participating! :p
4 years, 4 months ago (2016-08-08 01:59:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220863002/1
4 years, 4 months ago (2016-08-08 05:27:14 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 05:30:54 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 05:32:23 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d70bbabbe7641c768c9c2667658b6e85a4accb09
Cr-Commit-Position: refs/heads/master@{#410305}

Powered by Google App Engine
This is Rietveld 408576698