Cached style element sheets may not have an owner node.

Cached style element sheets may not have an owner node.

The assert for cacheability of shared StyleSheetContents required the
ownerNode to be a non-null style element. Referring to and modify a
stylesheet is however possible after the style element has been removed
and the ownerNode set to null. Change the assert to just check for the
two types of cacheability.

This was not triggered by stylesheets not having @media rules since the
cacheability of linked resources would be true and made the assert
true.

Also, made the ASSERT a DCHECK along with the other ASSERTs in the
modified file.

R=meade@chromium.org
BUG=635022
Committed: https://crrev.com/d70bbabbe7641c768c9c2667658b6e85a4accb09
Cr-Commit-Position: refs/heads/master@{#410305}

[rune, 2016-08-07 23:37:05]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-07 23:37:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rune, 2016-08-07 23:38:02]

ptal

[commit-bot: I haz the power, 2016-08-08 01:21:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 01:21:35]

Dry run: This issue passed the CQ dry run.

[meade_UTC10, 2016-08-08 01:59:16]

lgtm

Style team is having a clusterfuzz/crash bug fixit today, thanks for
participating! :p

[rune, 2016-08-08 05:26:54]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-08-08 05:27:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 05:30:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-08 05:32:22]

Description was changed from

==========
Cached style element sheets may not have an owner node.

The assert for cacheability of shared StyleSheetContents required the
ownerNode to be a non-null style element. Referring to and modify a
stylesheet is however possible after the style element has been removed
and the ownerNode set to null. Change the assert to just check for the
two types of cacheability.

This was not triggered by stylesheets not having @media rules since the
cacheability of linked resources would be true and made the assert
true.

Also, made the ASSERT a DCHECK along with the other ASSERTs in the
modified file.

R=meade@chromium.org
BUG=635022
==========

to

==========
Cached style element sheets may not have an owner node.

The assert for cacheability of shared StyleSheetContents required the
ownerNode to be a non-null style element. Referring to and modify a
stylesheet is however possible after the style element has been removed
and the ownerNode set to null. Change the assert to just check for the
two types of cacheability.

This was not triggered by stylesheets not having @media rules since the
cacheability of linked resources would be true and made the assert
true.

Also, made the ASSERT a DCHECK along with the other ASSERTs in the
modified file.

R=meade@chromium.org
BUG=635022

Committed: https://crrev.com/d70bbabbe7641c768c9c2667658b6e85a4accb09
Cr-Commit-Position: refs/heads/master@{#410305}
==========

[commit-bot: I haz the power, 2016-08-08 05:32:23]

Patchset 1 (id:??) landed as
https://crrev.com/d70bbabbe7641c768c9c2667658b6e85a4accb09
Cr-Commit-Position: refs/heads/master@{#410305}