Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2220823002:
Add a target //build/config/ios:xctest. (Closed)
|
Created:
4 years, 4 months ago by sdefresne Modified:
4 years, 4 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@refactor-bundle-creation Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd a target //build/config/ios:xctest.
Introduce a group target //build/config/ios:xctest to add a
config on //build/config/ios:xctest_config (it is easier to
use deps than configs).
BUG=629867
Committed: https://crrev.com/5cb24daa370c6c7156afbf17d00aa8af7d021c96
Cr-Commit-Position: refs/heads/master@{#410592}
Patch Set 1 #Patch Set 2 : Rebase on origin/master. #
Messages
Total messages: 23 (18 generated)
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Add a target //build/config/ios:xctest. Introduce a group target //build/config/ios:xctest to add a config on //build/config/ios:xctest_config (it is easier to use deps than configs). BUG=None ========== to ========== Add a target //build/config/ios:xctest. Introduce a group target //build/config/ios:xctest to add a config on //build/config/ios:xctest_config (it is easier to use deps than configs). BUG=629867 ==========
sdefresne@chromium.org changed reviewers: + dpranke@chromium.org
Please take a look.
Patchset #1 (id:1) has been deleted
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Patchset #1 (id:20001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
lgtm
The CQ bit was checked by sdefresne@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2220823002/#ps60001 (title: "Rebase.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add a target //build/config/ios:xctest. Introduce a group target //build/config/ios:xctest to add a config on //build/config/ios:xctest_config (it is easier to use deps than configs). BUG=629867 ========== to ========== Add a target //build/config/ios:xctest. Introduce a group target //build/config/ios:xctest to add a config on //build/config/ios:xctest_config (it is easier to use deps than configs). BUG=629867 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Add a target //build/config/ios:xctest. Introduce a group target //build/config/ios:xctest to add a config on //build/config/ios:xctest_config (it is easier to use deps than configs). BUG=629867 ========== to ========== Add a target //build/config/ios:xctest. Introduce a group target //build/config/ios:xctest to add a config on //build/config/ios:xctest_config (it is easier to use deps than configs). BUG=629867 Committed: https://crrev.com/5cb24daa370c6c7156afbf17d00aa8af7d021c96 Cr-Commit-Position: refs/heads/master@{#410592} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/5cb24daa370c6c7156afbf17d00aa8af7d021c96 Cr-Commit-Position: refs/heads/master@{#410592} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
