Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 22208002: Drop [IsIndex] IDL extended attribute from Speech types (Closed)

Created:
7 years, 4 months ago by do-not-use
Modified:
7 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, lgombos
Visibility:
Public.

Description

Drop [IsIndex] IDL extended attribute from Speech types Drop [IsIndex] IDL extended attribute from Speech types as the corresponding specifications do not mandate that we should throw an IndexsizeError exception on negative values: https://dvcs.w3.org/hg/speech-api/raw-file/tip/speechapi.html http://lists.w3.org/Archives/Public/public-xg-htmlspeech/2011Feb/att-0020/api-draft.html#speech_input_result_list_interface BUG=237739 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155587

Patch Set 1 #

Total comments: 4

Patch Set 2 : Stop using window.event #

Messages

Total messages: 9 (0 generated)
do-not-use
Firefox does not seem to support Web Speech or Speech input. Also, this should be ...
7 years, 4 months ago (2013-08-05 15:04:47 UTC) #1
arv (Not doing code reviews)
LGTM https://codereview.chromium.org/22208002/diff/1/LayoutTests/fast/speech/input-onspeechchange-event.html File LayoutTests/fast/speech/input-onspeechchange-event.html (right): https://codereview.chromium.org/22208002/diff/1/LayoutTests/fast/speech/input-onspeechchange-event.html#newcode10 LayoutTests/fast/speech/input-onspeechchange-event.html:10: function onSpeechChange() { Can you get rid of ...
7 years, 4 months ago (2013-08-05 15:15:28 UTC) #2
haraken
LGTM. Needs an approval from an API owner.
7 years, 4 months ago (2013-08-05 15:26:17 UTC) #3
do-not-use
https://codereview.chromium.org/22208002/diff/1/LayoutTests/fast/speech/input-onspeechchange-event.html File LayoutTests/fast/speech/input-onspeechchange-event.html (right): https://codereview.chromium.org/22208002/diff/1/LayoutTests/fast/speech/input-onspeechchange-event.html#newcode10 LayoutTests/fast/speech/input-onspeechchange-event.html:10: function onSpeechChange() { On 2013/08/05 15:15:28, arv wrote: > ...
7 years, 4 months ago (2013-08-05 15:27:45 UTC) #4
arv (Not doing code reviews)
https://codereview.chromium.org/22208002/diff/1/LayoutTests/fast/speech/input-onspeechchange-event.html File LayoutTests/fast/speech/input-onspeechchange-event.html (right): https://codereview.chromium.org/22208002/diff/1/LayoutTests/fast/speech/input-onspeechchange-event.html#newcode10 LayoutTests/fast/speech/input-onspeechchange-event.html:10: function onSpeechChange() { On 2013/08/05 15:27:45, Christophe Dumez wrote: ...
7 years, 4 months ago (2013-08-05 15:36:00 UTC) #5
do-not-use
On 2013/08/05 15:36:00, arv wrote: > https://codereview.chromium.org/22208002/diff/1/LayoutTests/fast/speech/input-onspeechchange-event.html > File LayoutTests/fast/speech/input-onspeechchange-event.html (right): > > https://codereview.chromium.org/22208002/diff/1/LayoutTests/fast/speech/input-onspeechchange-event.html#newcode10 > ...
7 years, 4 months ago (2013-08-05 15:39:08 UTC) #6
tkent
lgtm
7 years, 4 months ago (2013-08-05 22:21:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/22208002/8001
7 years, 4 months ago (2013-08-06 06:30:22 UTC) #8
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 08:03:12 UTC) #9
Message was sent while issue was closed.
Change committed as 155587

Powered by Google App Engine
This is Rietveld 408576698