Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2220793002:
Roll clang 274369:277962. (Closed)
|
Created:
4 years, 4 months ago by Nico Modified:
4 years, 4 months ago Reviewers:
hans CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, yunlian, Reid Kleckner, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, hans, dmikurube+clang_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll clang 274369:277962.
Ran `tools/clang/scripts/upload_revision.py 277909`.
New:
* version number is now 4.0.0
* much better debug info on Windows
* asan/win runtime detects EXCEPTION_ILLEGAL_INSTRUCTION / EXCEPTION_BREAKPOINT
* improved integrated assembler on arm
* sanitizer coverage improvements
* lto devirtualization fixes
* …and over 3500 other changes
This is the first clang roll with gn as default meta-buildsystem. With gyp,
all .o files got automatically rebuilt after clang rolls. With gn, this doesn't
always work (https://crbug.com/612340). If you're getting errors about
having to rebuild pch files after this roll (on Mac and Windows), manually
run `gn gen out/gn` (or whatever your build dir is) and then build again.
BUG=629966
TBR=hans
Committed: https://crrev.com/78f40fbff7fe6ea54b0de1492268f4f5f76f6eb6
Cr-Commit-Position: refs/heads/master@{#410289}
Patch Set 1 #Patch Set 2 : 4.0.0 #Patch Set 3 : 277910, fix VERSION #Patch Set 4 : 277962 #
Messages
Total messages: 23 (18 generated)
Description was changed from ========== Roll clang 274369:277909. Ran `tools/clang/scripts/upload_revision.py 277909`. BUG= ========== to ========== Roll clang 274369:277909. Ran `tools/clang/scripts/upload_revision.py 277909`. BUG=629966 ==========
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
Description was changed from ========== Roll clang 274369:277909. Ran `tools/clang/scripts/upload_revision.py 277909`. BUG=629966 ========== to ========== Roll clang 274369:277962. Ran `tools/clang/scripts/upload_revision.py 277909`. BUG=629966 ==========
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Roll clang 274369:277962. Ran `tools/clang/scripts/upload_revision.py 277909`. BUG=629966 ========== to ========== Roll clang 274369:277962. Ran `tools/clang/scripts/upload_revision.py 277909`. New: * version number is now 4.0.0 * much better debug info on Windows * asan/win runtime detects EXCEPTION_ILLEGAL_INSTRUCTION / EXCEPTION_BREAKPOINT * improved integrated assembler on arm This is the first clang roll with gn as default meta-buildsystem. With gyp, all .o files got automatically rebuilt after clang rolls. With gn, this doesn't always work (https://crbug.com/612340). If you're getting errors about having to rebuild pch files after this roll (on Mac and Windows), manually run `gn gen out/gn` (or whatever your build dir is) and then build again. BUG=629966 ==========
Description was changed from ========== Roll clang 274369:277962. Ran `tools/clang/scripts/upload_revision.py 277909`. New: * version number is now 4.0.0 * much better debug info on Windows * asan/win runtime detects EXCEPTION_ILLEGAL_INSTRUCTION / EXCEPTION_BREAKPOINT * improved integrated assembler on arm This is the first clang roll with gn as default meta-buildsystem. With gyp, all .o files got automatically rebuilt after clang rolls. With gn, this doesn't always work (https://crbug.com/612340). If you're getting errors about having to rebuild pch files after this roll (on Mac and Windows), manually run `gn gen out/gn` (or whatever your build dir is) and then build again. BUG=629966 ========== to ========== Roll clang 274369:277962. Ran `tools/clang/scripts/upload_revision.py 277909`. New: * version number is now 4.0.0 * much better debug info on Windows * asan/win runtime detects EXCEPTION_ILLEGAL_INSTRUCTION / EXCEPTION_BREAKPOINT * improved integrated assembler on arm * sanitizer coverage improvements * lto devirtualization fixes This is the first clang roll with gn as default meta-buildsystem. With gyp, all .o files got automatically rebuilt after clang rolls. With gn, this doesn't always work (https://crbug.com/612340). If you're getting errors about having to rebuild pch files after this roll (on Mac and Windows), manually run `gn gen out/gn` (or whatever your build dir is) and then build again. BUG=629966 ==========
Description was changed from ========== Roll clang 274369:277962. Ran `tools/clang/scripts/upload_revision.py 277909`. New: * version number is now 4.0.0 * much better debug info on Windows * asan/win runtime detects EXCEPTION_ILLEGAL_INSTRUCTION / EXCEPTION_BREAKPOINT * improved integrated assembler on arm * sanitizer coverage improvements * lto devirtualization fixes This is the first clang roll with gn as default meta-buildsystem. With gyp, all .o files got automatically rebuilt after clang rolls. With gn, this doesn't always work (https://crbug.com/612340). If you're getting errors about having to rebuild pch files after this roll (on Mac and Windows), manually run `gn gen out/gn` (or whatever your build dir is) and then build again. BUG=629966 ========== to ========== Roll clang 274369:277962. Ran `tools/clang/scripts/upload_revision.py 277909`. New: * version number is now 4.0.0 * much better debug info on Windows * asan/win runtime detects EXCEPTION_ILLEGAL_INSTRUCTION / EXCEPTION_BREAKPOINT * improved integrated assembler on arm * sanitizer coverage improvements * lto devirtualization fixes * …and over 3500 other changes This is the first clang roll with gn as default meta-buildsystem. With gyp, all .o files got automatically rebuilt after clang rolls. With gn, this doesn't always work (https://crbug.com/612340). If you're getting errors about having to rebuild pch files after this roll (on Mac and Windows), manually run `gn gen out/gn` (or whatever your build dir is) and then build again. BUG=629966 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Roll clang 274369:277962. Ran `tools/clang/scripts/upload_revision.py 277909`. New: * version number is now 4.0.0 * much better debug info on Windows * asan/win runtime detects EXCEPTION_ILLEGAL_INSTRUCTION / EXCEPTION_BREAKPOINT * improved integrated assembler on arm * sanitizer coverage improvements * lto devirtualization fixes * …and over 3500 other changes This is the first clang roll with gn as default meta-buildsystem. With gyp, all .o files got automatically rebuilt after clang rolls. With gn, this doesn't always work (https://crbug.com/612340). If you're getting errors about having to rebuild pch files after this roll (on Mac and Windows), manually run `gn gen out/gn` (or whatever your build dir is) and then build again. BUG=629966 ========== to ========== Roll clang 274369:277962. Ran `tools/clang/scripts/upload_revision.py 277909`. New: * version number is now 4.0.0 * much better debug info on Windows * asan/win runtime detects EXCEPTION_ILLEGAL_INSTRUCTION / EXCEPTION_BREAKPOINT * improved integrated assembler on arm * sanitizer coverage improvements * lto devirtualization fixes * …and over 3500 other changes This is the first clang roll with gn as default meta-buildsystem. With gyp, all .o files got automatically rebuilt after clang rolls. With gn, this doesn't always work (https://crbug.com/612340). If you're getting errors about having to rebuild pch files after this roll (on Mac and Windows), manually run `gn gen out/gn` (or whatever your build dir is) and then build again. BUG=629966 TBR=hans ==========
thakis@chromium.org changed reviewers: + hans@chromium.org
The roll put up quite a fight – as it always does when it's been a while, I suppose.
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Roll clang 274369:277962. Ran `tools/clang/scripts/upload_revision.py 277909`. New: * version number is now 4.0.0 * much better debug info on Windows * asan/win runtime detects EXCEPTION_ILLEGAL_INSTRUCTION / EXCEPTION_BREAKPOINT * improved integrated assembler on arm * sanitizer coverage improvements * lto devirtualization fixes * …and over 3500 other changes This is the first clang roll with gn as default meta-buildsystem. With gyp, all .o files got automatically rebuilt after clang rolls. With gn, this doesn't always work (https://crbug.com/612340). If you're getting errors about having to rebuild pch files after this roll (on Mac and Windows), manually run `gn gen out/gn` (or whatever your build dir is) and then build again. BUG=629966 TBR=hans ========== to ========== Roll clang 274369:277962. Ran `tools/clang/scripts/upload_revision.py 277909`. New: * version number is now 4.0.0 * much better debug info on Windows * asan/win runtime detects EXCEPTION_ILLEGAL_INSTRUCTION / EXCEPTION_BREAKPOINT * improved integrated assembler on arm * sanitizer coverage improvements * lto devirtualization fixes * …and over 3500 other changes This is the first clang roll with gn as default meta-buildsystem. With gyp, all .o files got automatically rebuilt after clang rolls. With gn, this doesn't always work (https://crbug.com/612340). If you're getting errors about having to rebuild pch files after this roll (on Mac and Windows), manually run `gn gen out/gn` (or whatever your build dir is) and then build again. BUG=629966 TBR=hans ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Roll clang 274369:277962. Ran `tools/clang/scripts/upload_revision.py 277909`. New: * version number is now 4.0.0 * much better debug info on Windows * asan/win runtime detects EXCEPTION_ILLEGAL_INSTRUCTION / EXCEPTION_BREAKPOINT * improved integrated assembler on arm * sanitizer coverage improvements * lto devirtualization fixes * …and over 3500 other changes This is the first clang roll with gn as default meta-buildsystem. With gyp, all .o files got automatically rebuilt after clang rolls. With gn, this doesn't always work (https://crbug.com/612340). If you're getting errors about having to rebuild pch files after this roll (on Mac and Windows), manually run `gn gen out/gn` (or whatever your build dir is) and then build again. BUG=629966 TBR=hans ========== to ========== Roll clang 274369:277962. Ran `tools/clang/scripts/upload_revision.py 277909`. New: * version number is now 4.0.0 * much better debug info on Windows * asan/win runtime detects EXCEPTION_ILLEGAL_INSTRUCTION / EXCEPTION_BREAKPOINT * improved integrated assembler on arm * sanitizer coverage improvements * lto devirtualization fixes * …and over 3500 other changes This is the first clang roll with gn as default meta-buildsystem. With gyp, all .o files got automatically rebuilt after clang rolls. With gn, this doesn't always work (https://crbug.com/612340). If you're getting errors about having to rebuild pch files after this roll (on Mac and Windows), manually run `gn gen out/gn` (or whatever your build dir is) and then build again. BUG=629966 TBR=hans Committed: https://crrev.com/78f40fbff7fe6ea54b0de1492268f4f5f76f6eb6 Cr-Commit-Position: refs/heads/master@{#410289} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/78f40fbff7fe6ea54b0de1492268f4f5f76f6eb6 Cr-Commit-Position: refs/heads/master@{#410289}
Message was sent while issue was closed.
lgtm |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
