Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 222073002: Revert of Refactor content/renderer/accessibility to use AXTreeSerializer. (Closed)

Created:
6 years, 8 months ago by pfeldman
Modified:
6 years, 8 months ago
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Visibility:
Public.

Description

Revert of Refactor content/renderer/accessibility to use AXTreeSerializer. (https://codereview.chromium.org/125763003/) Reason for revert: Breaks asan builders: http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20ASan%2BLSan%20Tests%20%283%29&number=1347 Original issue's description: > Refactor content/renderer/accessibility to use AXTreeSerializer. > > This removes the confusing code in content/renderer/accessibility that > serializes updates from Blink's accessibility tree, and replaces it with > calls to the new cleaner and fully-unit-tested AXTreeSerializer class. > > BUG=316726 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261099 TBR=dtseng@chromium.org,aboxhall@chromium.org,tsepez@chromium.org,jam@chromium.org,aarya@google.com,dmazzoni@chromium.org NOTREECHECKS=true NOTRY=true BUG=316726 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261107

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+917 lines, -711 lines) Patch
M content/browser/accessibility/browser_accessibility_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_unittest.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M content/common/accessibility_messages.h View 2 chunks +3 lines, -8 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
A content/renderer/accessibility/accessibility_node_serializer.h View 1 chunk +23 lines, -0 lines 0 comments Download
A content/renderer/accessibility/accessibility_node_serializer.cc View 1 chunk +486 lines, -0 lines 0 comments Download
D content/renderer/accessibility/blink_ax_tree_source.h View 1 chunk +0 lines, -46 lines 0 comments Download
D content/renderer/accessibility/blink_ax_tree_source.cc View 1 chunk +0 lines, -552 lines 0 comments Download
M content/renderer/accessibility/renderer_accessibility_browsertest.cc View 20 chunks +67 lines, -39 lines 0 comments Download
M content/renderer/accessibility/renderer_accessibility_complete.h View 5 chunks +38 lines, -9 lines 0 comments Download
M content/renderer/accessibility/renderer_accessibility_complete.cc View 7 chunks +272 lines, -31 lines 0 comments Download
M content/renderer/accessibility/renderer_accessibility_focus_only.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/accessibility/ax_tree_source.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
pfeldman
Created Revert of Refactor content/renderer/accessibility to use AXTreeSerializer.
6 years, 8 months ago (2014-04-02 11:29:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/222073002/1
6 years, 8 months ago (2014-04-02 11:29:50 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 11:31:36 UTC) #3
Message was sent while issue was closed.
Change committed as 261107

Powered by Google App Engine
This is Rietveld 408576698