[Payments] Add Payment Request metrics for selected payment method.

chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

Index: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
index 653f20b90c4aca3229ce8bd8f88e471b424def1e..e07b4ea5f40344ddc967659b4f8fa56562cc2dc9 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
@@ -1032,11 +1032,23 @@ public class PaymentRequestImpl implements PaymentRequest, PaymentRequestUI.Clie
             }
         }
 
-        // If the payment method was an Autofill credit card with an identifier, record its use.
-        if (mPaymentMethodsSection.getSelectedItem() instanceof AutofillPaymentInstrument
-                && !mPaymentMethodsSection.getSelectedItem().getIdentifier().isEmpty()) {
-            PersonalDataManager.getInstance().recordAndLogCreditCardUse(
-                    mPaymentMethodsSection.getSelectedItem().getIdentifier());
+        // Record the payment method used to complete the transaction. If the payment method was an
+        // Autofill credit card with an identifier, record its use.
+        if (mPaymentMethodsSection.getSelectedItem() instanceof AutofillPaymentInstrument) {
+            if (!mPaymentMethodsSection.getSelectedItem().getIdentifier().isEmpty()) {
+                PersonalDataManager.getInstance().recordAndLogCreditCardUse(
+                        mPaymentMethodsSection.getSelectedItem().getIdentifier());
+            }
+            PaymentRequestMetrics.recordSelectedPaymentMethodHistogram(
+                    PaymentRequestMetrics.SELECTED_METHOD_CREDIT_CARD);
+        } else {

[please use gerrit instead, 2016/08/05 22:08:26]

Instead of this:

if () {
} else {
  if () {
  } else {
  }
}

It's cleaner to write this:

if () {
} else if () {
} else {
}

[sebsg, 2016/08/08 16:16:50]

Done.

+            if (methodName.equals(PaymentRequestMetrics.getAndroidPayMethodName())) {
+                PaymentRequestMetrics.recordSelectedPaymentMethodHistogram(
+                        PaymentRequestMetrics.SELECTED_METHOD_ANDROID_PAY);
+            } else {
+                PaymentRequestMetrics.recordSelectedPaymentMethodHistogram(
+                        PaymentRequestMetrics.SELECTED_METHOD_OTHER_PAYMENT_APP);
+            }
         }
 
         mUI.showProcessingMessage();