chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppTest.java - Issue 2220713002: [Payments] Add Payment Request metrics for selected payment method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppTest.java

Issue 2220713002: [Payments] Add Payment Request metrics for selected payment method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppAndCardsTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppTest.java

index 7312837d881830573f9e4d6ddc29626f268a73f6..b17d7e2905810025d81b0a5c483d38f969af24e7 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppTest.java

@@ -66,7 +66,7 @@ public class PaymentRequestPaymentAppTest extends PaymentRequestTestBase {

@MediumTest

public void testPaymentWithInstrumentsAppResponseAfterDismissShouldNotCrash()

throws InterruptedException, ExecutionException, TimeoutException {

- final BobPay app = installPaymentApp(HAVE_INSTRUMENTS, IMMEDIATE_RESPONSE);

+ final TestPay app = installPaymentApp(HAVE_INSTRUMENTS, IMMEDIATE_RESPONSE);

triggerUIAndWait(mReadyForInput);

clickAndWait(R.id.close_button, mDismissed);

ThreadUtils.runOnUiThreadBlocking(new Runnable() {

@@ -84,7 +84,7 @@ public class PaymentRequestPaymentAppTest extends PaymentRequestTestBase {

@MediumTest

public void testPaymentAppNoInstrumentsResponseAfterDismissShouldNotCrash()

throws InterruptedException, ExecutionException, TimeoutException {

- final BobPay app = installPaymentApp(NO_INSTRUMENTS, IMMEDIATE_RESPONSE);

+ final TestPay app = installPaymentApp(NO_INSTRUMENTS, IMMEDIATE_RESPONSE);

triggerUIAndWait(mShowFailed);

ThreadUtils.runOnUiThreadBlocking(new Runnable() {

@Override