Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2220693002: Restore order of LayoutObject fields before crrev.com/402384 (Closed)

Created:
4 years, 4 months ago by Xianzhu
Modified:
4 years, 4 months ago
Reviewers:
pdr., chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restore order of LayoutObject fields before crrev.com/402384 In crrev.com/402384 we changed the order of LayoutObject fields to avoid memory gaps on 64-bit systems (which actually didn't work because it just moves the gap to after the fields). It caused performance regression of blink_perf.css.FocusUpdate on some Android devices, perhaps because of changed cache behavior. Restore the original LayoutObject field order. BUG=624241 Committed: https://crrev.com/6b109b4d67f5a3e18947b192f661f34f54e5f922 Cr-Commit-Position: refs/heads/master@{#410229}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutObject.h View 2 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Xianzhu
I guess this was because the LayoutPoint and LayoutRect fields were placed at odd 32-bit ...
4 years, 4 months ago (2016-08-05 21:24:20 UTC) #2
chrishtr
lgtm
4 years, 4 months ago (2016-08-05 22:50:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220693002/1
4 years, 4 months ago (2016-08-05 22:56:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-06 00:32:44 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-06 00:34:31 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b109b4d67f5a3e18947b192f661f34f54e5f922
Cr-Commit-Position: refs/heads/master@{#410229}

Powered by Google App Engine
This is Rietveld 408576698