Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 2220663002: Fixing uninitialized access in blink::ImagePattern::isLocalMatrixChanged (Closed)

Created:
4 years, 4 months ago by xlai (Olivia)
Modified:
4 years, 4 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Rik, f(malita), blink-reviews, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing uninitialized access in blink::ImagePattern::isLocalMatrixChanged Do an explicit setIdentity() call on m_previousLocalMatrix to avoid SKMatrix operator==() complaining an uninitialized access to its internal integer values. TBR=junov@chromium.org BUG=635045 Committed: https://crrev.com/b0f2b78559b1d731012d9808376c08b6ec256396 Cr-Commit-Position: refs/heads/master@{#410197}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/platform/graphics/ImagePattern.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220663002/1
4 years, 4 months ago (2016-08-05 21:17:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 22:34:26 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b0f2b78559b1d731012d9808376c08b6ec256396 Cr-Commit-Position: refs/heads/master@{#410197}
4 years, 4 months ago (2016-08-05 22:36:43 UTC) #7
Justin Novosad
4 years, 4 months ago (2016-08-09 14:36:55 UTC) #8
Message was sent while issue was closed.
On 2016/08/05 22:36:43, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/b0f2b78559b1d731012d9808376c08b6ec256396
> Cr-Commit-Position: refs/heads/master@{#410197}

lgtm

Powered by Google App Engine
This is Rietveld 408576698