Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5381)

Unified Diff: chrome/browser/ssl/ssl_error_handler.h

Issue 2220603003: Remove unnecessary |result| argument from AllowCertificateError() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove unnecessary include Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ssl/ssl_browser_tests.cc ('k') | chrome/browser/ssl/ssl_error_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/ssl_error_handler.h
diff --git a/chrome/browser/ssl/ssl_error_handler.h b/chrome/browser/ssl/ssl_error_handler.h
index f86c487e3116d9b0198f89732e6535e10ccc585a..6431dad304960c893a6cc85bf57ccb2e91caf1a5 100644
--- a/chrome/browser/ssl/ssl_error_handler.h
+++ b/chrome/browser/ssl/ssl_error_handler.h
@@ -56,13 +56,15 @@ class SSLErrorHandler : public content::WebContentsUserData<SSLErrorHandler>,
// Entry point for the class. The parameters are the same as SSLBlockingPage
// constructor.
- static void HandleSSLError(content::WebContents* web_contents,
- int cert_error,
- const net::SSLInfo& ssl_info,
- const GURL& request_url,
- int options_mask,
- std::unique_ptr<SSLCertReporter> ssl_cert_reporter,
- const base::Callback<void(bool)>& callback);
+ static void HandleSSLError(
+ content::WebContents* web_contents,
+ int cert_error,
+ const net::SSLInfo& ssl_info,
+ const GURL& request_url,
+ int options_mask,
+ std::unique_ptr<SSLCertReporter> ssl_cert_reporter,
+ const base::Callback<void(content::CertificateRequestResultType)>&
+ callback);
// Testing methods.
static void SetInterstitialDelayForTest(base::TimeDelta delay);
@@ -79,7 +81,8 @@ class SSLErrorHandler : public content::WebContentsUserData<SSLErrorHandler>,
const GURL& request_url,
int options_mask,
std::unique_ptr<SSLCertReporter> ssl_cert_reporter,
- const base::Callback<void(bool)>& callback);
+ const base::Callback<
+ void(content::CertificateRequestResultType)>& callback);
~SSLErrorHandler() override;
@@ -132,7 +135,7 @@ class SSLErrorHandler : public content::WebContentsUserData<SSLErrorHandler>,
const net::SSLInfo ssl_info_;
const GURL request_url_;
const int options_mask_;
- base::Callback<void(bool)> callback_;
+ base::Callback<void(content::CertificateRequestResultType)> callback_;
Profile* const profile_;
content::NotificationRegistrar registrar_;
« no previous file with comments | « chrome/browser/ssl/ssl_browser_tests.cc ('k') | chrome/browser/ssl/ssl_error_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698