Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: chrome/browser/ssl/ssl_blocking_page.cc

Issue 2220603003: Remove unnecessary |result| argument from AllowCertificateError() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove unnecessary include Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ssl/ssl_blocking_page.h ('k') | chrome/browser/ssl/ssl_browser_tests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/ssl_blocking_page.cc
diff --git a/chrome/browser/ssl/ssl_blocking_page.cc b/chrome/browser/ssl/ssl_blocking_page.cc
index 82bede2a2ce4c8b275753b133df3ce29bb60ce0e..c6f0890e44a7312ba5f4b5e202cf9582c509e93a 100644
--- a/chrome/browser/ssl/ssl_blocking_page.cc
+++ b/chrome/browser/ssl/ssl_blocking_page.cc
@@ -115,7 +115,7 @@ SSLBlockingPage::SSLBlockingPage(
int options_mask,
const base::Time& time_triggered,
std::unique_ptr<SSLCertReporter> ssl_cert_reporter,
- const base::Callback<void(bool)>& callback)
+ const base::Callback<void(content::CertificateRequestResultType)>& callback)
: SecurityInterstitialPage(web_contents, request_url),
callback_(callback),
ssl_info_(ssl_info),
@@ -240,7 +240,7 @@ void SSLBlockingPage::OnProceed() {
// Accepting the certificate resumes the loading of the page.
DCHECK(!callback_.is_null());
- callback_.Run(true);
+ callback_.Run(content::CERTIFICATE_REQUEST_RESULT_TYPE_CONTINUE);
callback_.Reset();
}
@@ -261,7 +261,7 @@ void SSLBlockingPage::NotifyDenyCertificate() {
if (callback_.is_null())
return;
- callback_.Run(false);
+ callback_.Run(content::CERTIFICATE_REQUEST_RESULT_TYPE_CANCEL);
callback_.Reset();
}
« no previous file with comments | « chrome/browser/ssl/ssl_blocking_page.h ('k') | chrome/browser/ssl/ssl_browser_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698