Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1058)

Unified Diff: android_webview/browser/aw_content_browser_client.cc

Issue 2220603003: Remove unnecessary |result| argument from AllowCertificateError() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/aw_content_browser_client.cc
diff --git a/android_webview/browser/aw_content_browser_client.cc b/android_webview/browser/aw_content_browser_client.cc
index 942b0c368ec4d4d8a51030f7c410db916ab7e7d6..5209fad3f5b9b214f18ca3f6ebe3aa777c148910 100644
--- a/android_webview/browser/aw_content_browser_client.cc
+++ b/android_webview/browser/aw_content_browser_client.cc
@@ -352,8 +352,8 @@ void AwContentBrowserClient::AllowCertificateError(
bool overridable,
bool strict_enforcement,
bool expired_previous_decision,
- const base::Callback<void(bool)>& callback,
- content::CertificateRequestResultType* result) {
+ const base::Callback<void(content::CertificateRequestResultType)>&
+ callback) {
AwContentsClientBridgeBase* client =
AwContentsClientBridgeBase::FromWebContents(web_contents);
bool cancel_request = true;
@@ -363,8 +363,9 @@ void AwContentBrowserClient::AllowCertificateError(
request_url,
callback,
&cancel_request);
- if (cancel_request)
- *result = content::CERTIFICATE_REQUEST_RESULT_TYPE_DENY;
+ if (cancel_request) {
nasko 2016/08/08 18:32:03 nit: No need for {} on one-line if statements.
estark 2016/08/08 20:00:13 Done.
+ callback.Run(content::CERTIFICATE_REQUEST_RESULT_TYPE_DENY);
+ }
}
void AwContentBrowserClient::SelectClientCertificate(

Powered by Google App Engine
This is Rietveld 408576698