Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: content/public/browser/content_browser_client.h

Issue 2220603003: Remove unnecessary |result| argument from AllowCertificateError() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove unnecessary include Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/ssl/ssl_policy.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
6 #define CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_ 6 #define CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <map> 10 #include <map>
(...skipping 442 matching lines...) Expand 10 before | Expand all | Expand 10 after
453 virtual QuotaPermissionContext* CreateQuotaPermissionContext(); 453 virtual QuotaPermissionContext* CreateQuotaPermissionContext();
454 454
455 // Gives the embedder a chance to register a custom QuotaEvictionPolicy for 455 // Gives the embedder a chance to register a custom QuotaEvictionPolicy for
456 // temporary storage. 456 // temporary storage.
457 virtual std::unique_ptr<storage::QuotaEvictionPolicy> 457 virtual std::unique_ptr<storage::QuotaEvictionPolicy>
458 GetTemporaryStorageEvictionPolicy(BrowserContext* context); 458 GetTemporaryStorageEvictionPolicy(BrowserContext* context);
459 459
460 // Informs the embedder that a certificate error has occured. If 460 // Informs the embedder that a certificate error has occured. If
461 // |overridable| is true and if |strict_enforcement| is false, the user 461 // |overridable| is true and if |strict_enforcement| is false, the user
462 // can ignore the error and continue. The embedder can call the callback 462 // can ignore the error and continue. The embedder can call the callback
463 // asynchronously. If |result| is not set to 463 // asynchronously.
464 // CERTIFICATE_REQUEST_RESULT_TYPE_CONTINUE, the request will be cancelled 464 virtual void AllowCertificateError(
465 // or denied immediately, and the callback won't be run. 465 WebContents* web_contents,
466 virtual void AllowCertificateError(WebContents* web_contents, 466 int cert_error,
467 int cert_error, 467 const net::SSLInfo& ssl_info,
468 const net::SSLInfo& ssl_info, 468 const GURL& request_url,
469 const GURL& request_url, 469 ResourceType resource_type,
470 ResourceType resource_type, 470 bool overridable,
471 bool overridable, 471 bool strict_enforcement,
472 bool strict_enforcement, 472 bool expired_previous_decision,
473 bool expired_previous_decision, 473 const base::Callback<void(CertificateRequestResultType)>& callback) {}
474 const base::Callback<void(bool)>& callback,
475 CertificateRequestResultType* result) {}
476 474
477 // Selects a SSL client certificate and returns it to the |delegate|. Note: 475 // Selects a SSL client certificate and returns it to the |delegate|. Note:
478 // |delegate| may be called synchronously or asynchronously. 476 // |delegate| may be called synchronously or asynchronously.
479 // 477 //
480 // TODO(davidben): Move this hook to WebContentsDelegate. 478 // TODO(davidben): Move this hook to WebContentsDelegate.
481 virtual void SelectClientCertificate( 479 virtual void SelectClientCertificate(
482 WebContents* web_contents, 480 WebContents* web_contents,
483 net::SSLCertRequestInfo* cert_request_info, 481 net::SSLCertRequestInfo* cert_request_info,
484 std::unique_ptr<ClientCertificateDelegate> delegate); 482 std::unique_ptr<ClientCertificateDelegate> delegate);
485 483
(...skipping 292 matching lines...) Expand 10 before | Expand all | Expand 10 after
778 // Allows an embedder to provide its own ExternalVideoSurfaceContainer 776 // Allows an embedder to provide its own ExternalVideoSurfaceContainer
779 // implementation. Return nullptr to disable external surface video. 777 // implementation. Return nullptr to disable external surface video.
780 virtual ExternalVideoSurfaceContainer* 778 virtual ExternalVideoSurfaceContainer*
781 OverrideCreateExternalVideoSurfaceContainer(WebContents* web_contents); 779 OverrideCreateExternalVideoSurfaceContainer(WebContents* web_contents);
782 #endif 780 #endif
783 }; 781 };
784 782
785 } // namespace content 783 } // namespace content
786 784
787 #endif // CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_ 785 #endif // CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
OLDNEW
« no previous file with comments | « content/browser/ssl/ssl_policy.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698