Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2220583002: Don't IAT patch SetUnhandledExceptionFilter when ASan is active (Closed)

Created:
4 years, 4 months ago by Reid Kleckner
Modified:
4 years, 4 months ago
Reviewers:
robertshield, inferno
CC:
chromium-reviews, pennymac+watch_chromium.org, caitkp+watch_chromium.org, penny
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't IAT patch SetUnhandledExceptionFilter when ASan is active ASan installs its own exception filter that ClusterFuzz needs to see. R=robertshield@chromium.org,inferno@chromium.org BUG=626373 Committed: https://crrev.com/3894e46c8c2702e12d2ddec12f186d7c1cf5c412 Cr-Commit-Position: refs/heads/master@{#410077}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome_elf/chrome_elf_main.cc View 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
Reid Kleckner
4 years, 4 months ago (2016-08-05 15:21:36 UTC) #1
inferno
lgtm, thanks for fixing this.
4 years, 4 months ago (2016-08-05 15:27:08 UTC) #2
robertshield
+Penny FYI, but this LGTM
4 years, 4 months ago (2016-08-05 15:36:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220583002/1
4 years, 4 months ago (2016-08-05 15:37:24 UTC) #5
Reid Kleckner
Thanks, sorry about the ifdefs.
4 years, 4 months ago (2016-08-05 15:38:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 16:33:02 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3894e46c8c2702e12d2ddec12f186d7c1cf5c412 Cr-Commit-Position: refs/heads/master@{#410077}
4 years, 4 months ago (2016-08-05 16:35:28 UTC) #9
Reid Kleckner
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2225453002/ by rnk@chromium.org. ...
4 years, 4 months ago (2016-08-05 18:00:06 UTC) #10
inferno
4 years, 4 months ago (2016-08-05 18:01:11 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2217283002/ by inferno@chromium.org.

The reason for reverting is: Hangs instead of sad tabs for Win ASAN builds.

See crashpad logs.
[13236:14660:0805/105718:ERROR:crashpad_client_win.cc(484)] haven't called
UseHandler()
.

Powered by Google App Engine
This is Rietveld 408576698